-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] use raw strings in ntuple_show for ease of reading #17784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 20 files 20 suites 3d 13h 0m 58s ⏱️ For more details on these failures, see this check. Results for commit c881e0e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really mind either way, but I think there are again formatting-only changes in the commit that make it hard to determine which lines just have whitespace-changes and which are actually modified...
I think it's safe to say that nothing was modified in such a way that its meaning changed, otherwise the related test would have failed. |
a3c5416
to
72ba59e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGETM
72ba59e
to
c881e0e
Compare
Aesthetic-only change: use raw strings instead of string concatenation for the expected values in ntuple_show.
Checklist: