[ntuple] use raw strings in ntuple_show for ease of reading #17784
Conversation
| + "* Field 1.1.2 : myFloat (float) *\n" | ||
| + "********************************************************************************\n" }; | ||
| std::string outputFields{ | ||
| "************************************ NTUPLE ************************************\n" |
There was a problem hiding this comment.
This portion is better matched the indentation/format.
There was a problem hiding this comment.
Not sure if I interpret this comment correctly: you mean you like this more than the raw strings? In this case I could do without a raw string because there are no tons of " to escape, so it works; in all other cases I personally find the raw string much more readable.
However, as it's a subjective choice, the only way to decide is by majority vote I think.
| + " \"atomic\": false\n" | ||
| + "}\n" }; | ||
| std::string fString{ | ||
| R"({ |
There was a problem hiding this comment.
This PR both this syntax and compile time string concatenation (#17784 (comment)).
The main disadvantage (not fatal) is that this section is not indented like the surrounding code (whereas the other syntax is).
There was a problem hiding this comment.
True, but I'd argue the advantage in having a "heredoc-style" string where you see the expected output 1:1 outweighs the misindentation
Test Results 18 files 18 suites 4d 9h 22m 49s ⏱️ Results for commit a3c5416. |
Aesthetic-only change: use raw strings instead of string concatenation for the expected values in ntuple_show.
Checklist: