Skip to content

[ntuple] use raw strings in ntuple_show for ease of reading #17784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

silverweed
Copy link
Contributor

Aesthetic-only change: use raw strings instead of string concatenation for the expected values in ntuple_show.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed requested review from hahnjo and enirolf February 20, 2025 14:43
@silverweed silverweed self-assigned this Feb 20, 2025
@silverweed silverweed requested a review from jblomer as a code owner February 20, 2025 14:43
Copy link

github-actions bot commented Feb 20, 2025

Test Results

    20 files      20 suites   3d 13h 0m 58s ⏱️
 3 275 tests  3 271 ✅ 0 💤 4 ❌
63 846 runs  63 842 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit c881e0e.

♻️ This comment has been updated with latest results.

Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really mind either way, but I think there are again formatting-only changes in the commit that make it hard to determine which lines just have whitespace-changes and which are actually modified...

@silverweed
Copy link
Contributor Author

there are again formatting-only changes in the commit that make it hard to determine which lines just have whitespace-changes and which are actually modified...

I think it's safe to say that nothing was modified in such a way that its meaning changed, otherwise the related test would have failed.

@silverweed silverweed force-pushed the ntuple_show_rawstr branch from a3c5416 to 72ba59e Compare July 2, 2025 09:47
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGETM

@silverweed silverweed force-pushed the ntuple_show_rawstr branch from 72ba59e to c881e0e Compare July 10, 2025 07:01
@silverweed silverweed merged commit 03c374f into root-project:master Jul 11, 2025
23 of 25 checks passed
@silverweed silverweed deleted the ntuple_show_rawstr branch July 11, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants