[ntuple] Fix RClassField not resolving context-dependent typedefs #17783
+106
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
reviewed
Feb 20, 2025
pcanal
reviewed
Feb 20, 2025
Test Results 18 files 18 suites 4d 8h 24m 49s ⏱️ Results for commit a246042. ♻️ This comment has been updated with latest results. |
hahnjo
reviewed
Feb 21, 2025
There was a problem hiding this comment.
I agree with Philippe, we should verify that the fields (including class member fields) have the expected type names and aliases. Maybe this should go to tree/ntuple/v7/test/ntuple_type_name.cxx though and we keep ntuple_types.cxx about being able to write and read the data.
silverweed
force-pushed
the
ntuple_fix_field_typenorm
branch
from
a9a95c1 to
8c72814
Compare
We are currently using GetFullTypeName (aka the unresolved type of the field) and relying on later type renormalization, but this will fail to lookup the proper type in RFieldBase::Create() when the type is a context-dependent type, like a templated typedef contained inside a class. With this commit, we instead use the already-resolved type (TDataMember::GetTrueTypeName()) to create the field and then assign the type alias manually to the FullTypeName
silverweed
force-pushed
the
ntuple_fix_field_typenorm
branch
from
8c72814 to
a246042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
With #17637 we started using
TDataMember::GetFullTypeName()for the type name of RClassField's subfields, relying on later type renormalization. However, this approach fails when the type in question cannot be looked up by TClass::GetClass because it's context dependent (e.g. a templated typedef inside a class).This PR goes back to use
TDataMember::GetTrueTypeName()instead, and assigns the FullTypeName to the type alias of the created subfield. This allows handling cases of context-dependent typedefs, as we use the already-resolved type when creating the subfield.Checklist:
This PR fixes #17774