Expose contiguousness from TTreeReaderArray and use it #17781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
reviewed
Feb 20, 2025
Test Results 18 files 18 suites 4d 7h 36m 47s ⏱️ Results for commit 025c24d. ♻️ This comment has been updated with latest results. |
TTreeReaderArray now exposes information on whether the underlying array type uses contiguous memory. This info is in turn used by RDataFrame to optimise reading collections as RVec. Fixes https://its.cern.ch/jira/browse/ROOT-10823
vepadulano
force-pushed
the
ttreereaderarray-iscontiguous
branch
from
773d8f3 to
025c24d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TTreeReaderArray now exposes information on whether the underlying array type uses contiguous memory. This info is in turn used by RDataFrame to optimise reading collections as RVec.
Fixes https://its.cern.ch/jira/browse/ROOT-10823