-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join with constant memory footprint #124
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added warning for slow rows.
Added column selector
Fix issue with fail table column order and more granular tqdm
Added column selector docstrings
Fix an issue with page that is already cast pages
…s not technically a bug but makes things nicer
fix minor issue
fix issue with string slicing
…oader couldn't load it added tests for page loading parity i forgot to add
Fix scalar pages, fix unicode slicer
I'll close the and re-open it from my fork, seems that my git decided to push to the master repo instead of fork for whatever reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@realratchet @cerv15
Join has been optimized for speed using
numpy
and to maintain a constant memory footprint equal to 4 pages (4M values).Occasionally (1 in 100) I can trigger the following error during multiprocessing:
I believe this is not a join bug, but rather a multiprocessing problem. @realratchet ?