Auto sort modules by dependency order and review native function errors #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pause125
requested review from
jolestar,
baichuan3,
wow-sven and
stevenlaw123
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jolestar
reviewed
Oct 15, 2023
pause125
force-pushed
the
module-order
branch
from
6825912 to
cb16656
Compare
jolestar
reviewed
Oct 16, 2023
| @@ -19,8 +19,10 @@ module moveos_std::raw_table { | |||
| const ErrorAlreadyExists: u64 = 1; | |||
| /// Can not found the key in the table | |||
| const ErrorNotFound: u64 = 2; | |||
| /// Duplicate operation on the table | |||
| const ErrorDuplicateOperation: u64 = 3; | |||
There was a problem hiding this comment.
These errors are different from the raw_table native implemention.
There was a problem hiding this comment.
ErrorNotEmpty is only used in raw_table.move, not in native functions. Should we defined an unused ErrorNotEmpty in native function?
There was a problem hiding this comment.
It is better to define it and make sure the error code in Rust is consistent with error code in Move.
pause125
force-pushed
the
module-order
branch
from
cb16656 to
6344919
Compare
|
abort code is not wrapped with |
pause125
force-pushed
the
module-order
branch
from
6344919 to
af7859c
Compare
jolestar
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary