-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gh-1622] remove resource account in account.move. #1714
[gh-1622] remove resource account in account.move. #1714
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
82ab117
to
1a82e3b
Compare
1a82e3b
to
cea2f9d
Compare
How about this PR? |
Still ongoing. Plan to finish it in the weekend or the next week. |
we need to release a new framework version #1683 |
cea2f9d
to
bb53993
Compare
Committed. If you meant to just add AccountHolder struct in the example that used resource account previously, I'm glad to modify it. |
/// ResourceAccount can only be stored under address, not in other structs. | ||
struct ResourceAccount has key {} | ||
// Account holder holds an account of the resource | ||
struct AccountHolder has key { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not need the Holder in framework. Framework provide function to create Object, the application can hold Object as resource account.
@@ -99,6 +94,15 @@ module moveos_std::account { | |||
(signer, signer_cap) | |||
} | |||
|
|||
/// This is a helper function to generate seed for resource address | |||
fun generate_seed_bytes(addr: &address): vector<u8> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not need this
}); | ||
|
||
let account_address = signer::address_of(account); | ||
account::create_account_holder_object(account_address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just create a new Object and hold the Object in game.
bb53993
to
4c3dc74
Compare
How to resolve the incompatible version updates? |
cargo run --package framework-release --bin framework-release -- -v 3 --no-check-compatibility |
4c3dc74
to
95128a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example needs to be updated.
95128a2
to
bf02579
Compare
bf02579
to
c8feff2
Compare
Summary
ResourceAccount
.Example: steal_split.move.