ci(bench): refactor benchmark configuration and update related files #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 14, 2024 05:10
The tx_exec_benchmark function has been moved from the `tx` module to a new `tx_exec` module. This included updating import paths in both the function's definition and where it is used, in `bench_tx_exec.rs` and `bench_tx_exec_blk.rs`. The commit improves the organization of the codebase by placing each major functionality in its own module.
The benchmark files `bench_tx.rs` and `bench_tx_query.rs` have been deleted as part of code cleanup. This removal is reflected in the project configuration file, `Cargo.toml` as well, thereby ensuring that these benchmarks are no longer part of the build process. TODO: need new one
This commit refactors the configuration of the benchmarking function, moving the setup code into a new `config.rs` file. The main focus of this commit is to streamline the configuration of benchmarks, making it easier to adjust settings for different benchmarks. It introduces a new `BenchTxConfig` struct for defining the benchmark configuration and uses it to replace the previous use of environment variables. This commit also modifies various files to match the new configuration method.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit refactors the configuration of the benchmarking function, moving the setup code into a new
config.rsfile. The main focus of this commit is to streamline the configuration of benchmarks, making it easier to adjust settings for different benchmarks. It introduces a newBenchTxConfigstruct for defining the benchmark configuration and uses it to replace the previous use of environment variables. This commit also modifies various files to match the new configuration method.