Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gh-1554] upgrade rust version and fix syntax errors. #1555

Merged

Conversation

ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 11:36am

@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator Author

ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 commented Apr 12, 2024

Help debug GitHub CI. @jolestar @popcnt1 @yourmoonlight

@jolestar
Copy link
Contributor

It seems like Rustup does not support it.

profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html --component rustfmt --component clippy
error: error: invalid value '[toolchain]
profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html' for '<toolchain>...': invalid toolchain name: '[toolchain]
profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html'

For more information, try '--help'.
: invalid toolchain name: '[toolchain]
profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html'
Error: The process '/home/runner/.cargo/bin/rustup' failed with exit code 1

@popcnt1
Copy link
Collaborator

popcnt1 commented Apr 12, 2024

Help debug GitHub CI. @jolestar @popcnt-subodhi @yourmoonlight

Will work on it soon.

@jolestar Let me figure it out, take a break

@popcnt1
Copy link
Collaborator

popcnt1 commented Apr 12, 2024

@feliciss

try to remove inputs in .github/actions/rust-setup/action.yaml in action-rs(https://github.com/marketplace/actions/rust-toolchain)

reason:

CI rely on actions-rs/toolchain to install rust toolchain, and " Input has higher priority, so if you are want to use toolchain file, you need to remove the input from the workflow file."

rust-toolchain Outdated Show resolved Hide resolved
Copy link
Collaborator

@popcnt1 popcnt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. default profile to install toolchain
  2. fix input in rust-setup/action.yaml
  3. try 1.75.0? (it's a good time to upgrade rust)

@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator Author

  1. default profile to install toolchain
  2. fix input in rust-setup/action.yaml
  3. try 1.75.0? (it's a good time to upgrade rust)

I tried to remove action.yaml but there still has issue.

@popcnt1
Copy link
Collaborator

popcnt1 commented Apr 14, 2024

  1. default profile to install toolchain
  2. fix input in rust-setup/action.yaml
  3. try 1.75.0? (it's a good time to upgrade rust)

I tried to remove action.yaml but there still has issue.

  1. check_build_test(which you failed workflow) run on main branch (you could check it in the source code)
  2. you could create a new PR to just modify .github/actions/rust-setup/action.yaml, and keep 1.74.0 firstly for checking new toolchain config works. Then another PR upgrade the rust version

@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 changed the title [gh-1554] fix rust-toolchain build issue with other package managers. [gh-1554] upgrade rust version and fix syntax errors. Apr 15, 2024
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator Author

  1. default profile to install toolchain
  2. fix input in rust-setup/action.yaml
  3. try 1.75.0? (it's a good time to upgrade rust)

I tried to remove action.yaml but there still has issue.

  1. check_build_test(which you failed workflow) run on main branch (you could check it in the source code)
  2. you could create a new PR to just modify .github/actions/rust-setup/action.yaml, and keep 1.74.0 firstly for checking new toolchain config works. Then another PR upgrade the rust version

I made this PR to just upgrading rust version. The rust-toolchain file format remains the same to be resolved.

@jolestar jolestar merged commit 0b7533f into rooch-network:main Apr 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] using asdf rust plugin to build rust toolchain results in incompatible errors.
3 participants