Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle type for blob props #1

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Bundle type for blob props #1

merged 1 commit into from
Jan 31, 2025

Conversation

leo
Copy link
Member

@leo leo commented Jan 31, 2025

This change ensures that the TypeScript type used for the src prop on the Image component is bundled as part of the React client package, instead of being loaded from the separate ronin package.

@leo leo added the enhancement New feature or request label Jan 31, 2025
@leo leo requested review from NuroDev, juriadams and colodenn January 31, 2025 14:42
Copy link

Released an experimental package:

bun add @ronin/react@types-experimental-1

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@leo leo marked this pull request as ready for review January 31, 2025 14:45
@leo leo enabled auto-merge (squash) January 31, 2025 14:45
@leo leo merged commit 6e26fce into main Jan 31, 2025
3 checks passed
@leo leo deleted the types branch January 31, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants