refactor name of function

pkg/listener/chain_listener.go

@@ -119,7 +119,7 @@ func (l *ChainListener) getFinalizedBlockNumber(rpcEndpoint string) (uint64, err
 		return 0, err
 	}
 
-	number, err := utils.ConvertHexaStringToIntWithBuffer(rs.Result.Number, BufferBlock)
+	number, err := utils.ParseBlockNumberWithOptionalDelay(rs.Result.Number, BufferBlock)
 	return number, err
 }
 

pkg/utils/utils.go

@@ -46,7 +46,8 @@ func Max(a, b uint64) uint64 {
 	return b
 }
 
-func ConvertHexaStringToIntWithBuffer(s string, buffer uint64) (uint64, error) {
+// Convert HexString to Uin64 with optional delay, delay is subtracted from the result.
+func ParseBlockNumberWithOptionalDelay(s string, delay uint64) (uint64, error) {
 	s = strings.TrimSpace(s)
 	// Strip the "0x" prefix if present
 	if strings.HasPrefix(s, "0x") {
@@ -61,8 +62,8 @@ func ConvertHexaStringToIntWithBuffer(s string, buffer uint64) (uint64, error) {
 	if err != nil {
 		return 0, err
 	}
-	if number < buffer {
+	if number < delay {
 		return 0, fmt.Errorf("invalid hexa string %s", s)
 	}
-	return number - buffer, nil
+	return number - delay, nil
 }

tests/util_test.go

@@ -60,7 +60,7 @@ func TestMax(t *testing.T) {
 	}
 }
 
-func TestConvertHexaStringToIntWithBuffer(t *testing.T) {
+func TestParseBlockNumberWithOptionalDelay(t *testing.T) {
 	const (
 		bufferBlock = 2
 	)
@@ -75,6 +75,7 @@ func TestConvertHexaStringToIntWithBuffer(t *testing.T) {
 		{"0x1234", bufferBlock, 4658, ""},
 		{"  0x1234  ", bufferBlock, 4658, ""},
 		{" 1234", bufferBlock, 4658, ""},
+		{"0x1234", 0, 4660, ""},
 		{"0x1", bufferBlock, 0, "invalid hexa string"},
 		{"0x", bufferBlock, 0, "invalid hexa string"},
 		{"    ", bufferBlock, 0, "invalid hexa string"},
@@ -83,7 +84,7 @@ func TestConvertHexaStringToIntWithBuffer(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		result, err := utils.ConvertHexaStringToIntWithBuffer(tc.input, tc.buffer)
+		result, err := utils.ParseBlockNumberWithOptionalDelay(tc.input, tc.buffer)
 		if result != tc.expected {
 			t.Errorf("ConvertHexaStringToIntWithBuffer(%q, %v) = %v; want %v", tc.input, tc.buffer, result, tc.expected)
 		}