Modifying the diff.groovy with yaml project-to-test-on.yaml #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romani
requested changes
May 30, 2024
There was a problem hiding this comment.
we have no CI here.
please share some CLI prove that you executed it and it works.
please add yaml file config to your commit.
update commit message with prefix "Issue checkstyle#866: ..."
items:
| def projects = [] | ||
| def fullParamListSize = 5 | ||
|
|
||
| new File(listOfProjectsFile).eachLine { project -> |
There was a problem hiding this comment.
do not remove old functionality
please do check that file is with yaml extension and load it in yaml way, ELSE load it in "property"/old way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the diff.groovy with project-to-test-on.yaml
checkstyle#866