Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct users to also install dotenv #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wwaaijer
Copy link

@wwaaijer wwaaijer commented Nov 7, 2024

Hey there 👋

Since dotenv is a peer dependency now, to use dotenv-safe users will also need to install dotenv.
Currently this is not entirely clear from the installation instructions.

It's nice as a (first time) user to copy paste the installation instructions and have it work.
Currently, when blindly follow the instructions, they'll either get a warning from their package manager or a runtime error when trying to use dotenv-safe.

@rolodato
Copy link
Owner

Which package manager are you using? In my testing, only Yarn doesn't install peer dependencies by default.

@wwaaijer
Copy link
Author

Hey, thanks for looking into this! When I encountered this issue I was indeed using Yarn.

Since the dotenv was not listed as an actual dependency for the other package managers, I though it might matter. But with some quick testing I was not able to come up with a breaking setup for the other package managers.

The PR is updated to only instruct Yarn users to also add dotenv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants