Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete JSON-RPC proxy #37

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore: delete JSON-RPC proxy #37

merged 1 commit into from
Nov 12, 2024

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Nov 8, 2024

Overview

Resolves #34

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed the JSON-RPC client and server implementation, including related configuration and error handling structures.
    • Deleted associated unit tests for the JSON-RPC client-server interactions.
    • This update simplifies the codebase by eliminating unused components related to the JSON-RPC protocol.

@tzdybal tzdybal self-assigned this Nov 8, 2024
Copy link

coderabbitai bot commented Nov 8, 2024

Walkthrough

The changes involve the complete removal of the JSON-RPC proxy implementation, including the client, server, configuration, error handling, and associated tests. This deletion encompasses the client.go, client_server_test.go, config.go, errors.go, proxy_test.go, and server.go files, which collectively provided the functionality for a JSON-RPC proxy client-server architecture. The removal aligns with the objective to simplify the codebase by eliminating unused components.

Changes

File Change Summary
proxy/jsonrpc/client.go Removed Client struct, NewClient, and all associated methods related to the JSON-RPC client.
proxy/jsonrpc/client_server_test.go Deleted unit tests for JSON-RPC client-server interactions.
proxy/jsonrpc/config.go Removed Config struct and DefaultConfig function for JSON-RPC configuration management.
proxy/jsonrpc/errors.go Deleted jsonRPCError struct and associated error codes and variables.
proxy/jsonrpc/proxy_test.go Removed ProxyTestSuite struct and all related test methods for the proxy implementation.
proxy/jsonrpc/server.go Deleted Server struct and all associated methods for handling JSON-RPC server requests.

Assessment against linked issues

Objective Addressed Explanation
Remove JSON-RPC proxy (34)

🐇 In the meadow, we hop and play,
The JSON-RPC has gone away.
With a leap and a bound, we cheer,
Simplicity's here, let’s spread the cheer!
No more proxies, just fields of green,
A cleaner codebase, oh what a scene! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 291f759 and 82bd69f.

📒 Files selected for processing (6)
  • proxy/jsonrpc/client.go (0 hunks)
  • proxy/jsonrpc/client_server_test.go (0 hunks)
  • proxy/jsonrpc/config.go (0 hunks)
  • proxy/jsonrpc/errors.go (0 hunks)
  • proxy/jsonrpc/proxy_test.go (0 hunks)
  • proxy/jsonrpc/server.go (0 hunks)
💤 Files with no reviewable changes (6)
  • proxy/jsonrpc/client.go
  • proxy/jsonrpc/client_server_test.go
  • proxy/jsonrpc/config.go
  • proxy/jsonrpc/errors.go
  • proxy/jsonrpc/proxy_test.go
  • proxy/jsonrpc/server.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RollkitBot RollkitBot requested review from a team, tuxcanfly, yarikbratashchuk and gupadhyaya and removed request for a team November 8, 2024 19:45
@tzdybal tzdybal requested review from MSevey and Manav-Aggarwal and removed request for tuxcanfly November 8, 2024 19:45
@gupadhyaya gupadhyaya added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit c59fcaf Nov 12, 2024
19 checks passed
@gupadhyaya gupadhyaya deleted the tzdybal/remove_json_proxy branch November 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove JSON-RPC proxy
3 participants