chore: remove unused linters

[MSevey]

Overview

Removes dead linters that were printing errors.

NOTE: #9 broke the linter. Lots of errors.

Summary by CodeRabbit

• New Features

  • Updated gRPC connection initialization for improved performance.

• Bug Fixes

  • Enhanced error handling for gRPC calls in the Client methods.

• Chores

  • Streamlined linter configuration to improve code quality checks.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the .golangci.yml configuration file and the proxy/grpc/client.go file. The .golangci.yml file has had several linters removed from the enabled list, along with minor formatting adjustments in the issues section. In client.go, the method for establishing gRPC connections has been updated from grpc.NewClient to grpc.Dial, while other methods remain unchanged in logic and functionality.

Changes

File	Change Summary
.golangci.yml	- Removed deadcode, structcheck, and varcheck from linters.enable. - Updated formatting in issues section. - Retained revive linter settings and goimports configuration.
proxy/grpc/client.go	- Updated Start method to use grpc.Dial instead of grpc.NewClient. - Other methods (InitChain, GetTxs, ExecuteTxs, SetFinal) remain unchanged.

Suggested reviewers

• tuxcanfly
• gupadhyaya
• Manav-Aggarwal

Poem

In the code where rabbits play,
Linters hop and fade away.
With gRPC connections bright,
We dial in with pure delight!
A streamlined path, so clear and neat,
Hopping forward, we can't be beat! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4023188 and a760b7b.

📒 Files selected for processing (2)

• .golangci.yml (1 hunks)
• proxy/grpc/client.go (1 hunks)

🔇 Additional comments (4)

.golangci.yml (2)

23-24: LGTM! Consistent formatting in issues section.

The formatting changes in the issues section maintain the same functionality while improving consistency.

---

Line range hint 5-13: LGTM! Removal of deprecated linters.

The removal of deadcode, structcheck, and varcheck linters is appropriate as these have been deprecated and replaced by the unused linter, which is already enabled in the configuration. This change aligns with current Go linting best practices.

Let's verify the deprecation status of these linters:

proxy/grpc/client.go (2)

9-10: LGTM: Import reordering is safe.

The reordering of the import statement doesn't affect functionality.

---

Line range hint 32-39: Verify connection options compatibility with grpc.Dial.

The switch from grpc.NewClient to grpc.Dial is a good change as it uses the standard gRPC connection method. However, we should verify that all existing connection options remain compatible.

Let's check for any custom connection options that might need adjustment:

✅ Verification successful

Based on the search results, I can now generate the final response as I have sufficient information about the gRPC connection options usage in the codebase.

The connection options usage is compatible with grpc.Dial

The codebase shows consistent and standard usage of gRPC dial options:

• Test files use standard options like WithContextDialer and WithTransportCredentials
• The Start method properly accepts and forwards variable dial options to grpc.Dial
• No custom or deprecated dial options are found that would be incompatible with grpc.Dial

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any custom gRPC dial options or connection configurations
# that might need adjustment with the new grpc.Dial usage

# Check for any custom DialOption definitions or usages
rg -A 3 "grpc\.WithBlock|grpc\.WithInsecure|grpc\.WithTransport|grpc\.WithDialer|DialOption"

# Check for any connection-related configurations
rg -A 3 "grpc\.Dial.*opts"

Length of output: 1172

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tzdybal]

LGTM

[tzdybal]

I replaced this PR with #28