fix(da): fix metrics init

main.go

@@ -13,6 +13,7 @@ import (
 	"time"
 
 	"github.com/prometheus/client_golang/prometheus/promhttp"
+
 	"github.com/rollkit/centralized-sequencer/sequencing"
 	sequencingGRPC "github.com/rollkit/go-sequencing/proxy/grpc"
 )
@@ -68,15 +69,15 @@ func main() {
 		go func() {
 			log.Printf("Starting metrics server on %v...\n", metricsAddress)
 			http.Handle("/metrics", promhttp.Handler())
-			err := http.ListenAndServe(metricsAddress, nil)
+			err := http.ListenAndServe(metricsAddress, nil) // #nosec G114
 			if err != nil {
 				log.Fatalf("Failed to serve metrics: %v", err)
 			}
 		}()
 	}
 
-	metrics := sequencing.DefaultMetricsProvider(metricsEnabled, da_namespace)
-	centralizedSeq, err := sequencing.NewSequencer(da_address, da_auth_token, namespace, batchTime, metrics(""))
+	metrics := sequencing.DefaultMetricsProvider(metricsEnabled)("") // TODO use rollupId as chain_id
+	centralizedSeq, err := sequencing.NewSequencer(da_address, da_auth_token, namespace, batchTime, metrics)
 	if err != nil {
 		log.Fatalf("Failed to create centralized sequencer: %v", err)
 	}

sequencing/metrics.go

@@ -18,10 +18,10 @@ type MetricsProvider func(chainID string) *Metrics
 
 // DefaultMetricsProvider returns Metrics build using Prometheus client library
 // if Prometheus is enabled. Otherwise, it returns no-op Metrics.
-func DefaultMetricsProvider(enabled bool, namespace string) MetricsProvider {
+func DefaultMetricsProvider(enabled bool) MetricsProvider {
 	return func(chainID string) *Metrics {
 		if enabled {
-			return PrometheusMetrics(namespace, "chain_id", chainID)
+			return PrometheusMetrics("chain_id", chainID)
 		}
 		return NopMetrics()
 	}
@@ -49,7 +49,7 @@ type Metrics struct {
 // PrometheusMetrics returns Metrics build using Prometheus client library.
 // Optionally, labels can be provided along with their values ("foo",
 // "fooValue").
-func PrometheusMetrics(namespace string, labelsAndValues ...string) *Metrics {
+func PrometheusMetrics(labelsAndValues ...string) *Metrics {
 	labels := []string{}
 	for i := 0; i < len(labelsAndValues); i += 2 {
 		labels = append(labels, labelsAndValues[i])

sequencing/sequencer.go

@@ -124,8 +124,7 @@ type Sequencer struct {
 	seenBatches map[string]struct{}
 	bq          *BatchQueue
 
-	metricsProvider MetricsProvider
-	metrics         *Metrics
+	metrics *Metrics
 }
 
 // NewSequencer ...

sequencing/sequencer_test.go

@@ -51,7 +51,7 @@ func TestNewSequencer(t *testing.T) {
 	// mockDAClient := new(da.DAClient)
 
 	// Create a new sequencer with mock DA client
-	seq, err := NewSequencer(MockDAAddressHTTP, "authToken", []byte("namespace"), 10*time.Second)
+	seq, err := NewSequencer(MockDAAddressHTTP, "authToken", []byte("namespace"), 10*time.Second, NopMetrics())
 	require.NoError(t, err)
 
 	// Check if the sequencer was created with the correct values
@@ -63,7 +63,7 @@ func TestNewSequencer(t *testing.T) {
 
 func TestSequencer_SubmitRollupTransaction(t *testing.T) {
 	// Initialize a new sequencer
-	seq, err := NewSequencer(MockDAAddressHTTP, "authToken", []byte("namespace"), 10*time.Second)
+	seq, err := NewSequencer(MockDAAddressHTTP, "authToken", []byte("namespace"), 10*time.Second, NopMetrics())
 	require.NoError(t, err)
 
 	// Test with initial rollup ID