[2024Q4] Decision Making Tool #1714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EternalRival
requested review from
sergeyshalyapin,
natein,
muannna,
WiiJoy and
stardustmeg
as code owners
muannna
approved these changes
Jan 27, 2025
KristiBo
approved these changes
Jan 31, 2025
Co-authored-by: Kristina <[email protected]>
EternalRival
commented
Jan 31, 2025
TELEUZI
reviewed
Feb 8, 2025
EternalRival
commented
Feb 8, 2025
|
|
||
| ### Code Quality (80 points) | ||
|
|
||
| > The use of innerHTML is prohibited. Use of DOM search methods is prohibited. ([there are good reasons for not using them](https://gist.github.com/TELEUZI/410d19772481d98b06e0b41ebf89fff1#naive-implementation-).) |
There was a problem hiding this comment.
In the penalties section these methods are mentioned like this:
(querySelector*, getElement*, etc.)
If you don't mind, help me to correct that part here in the requirements and penalties
EternalRival
commented
Feb 8, 2025
Comment on lines
90
to
110
| 4. (+8) ESLint configuration file must include all of the following rules included: | ||
|
|
||
| ```json | ||
| { | ||
| "@typescript-eslint/consistent-type-imports": "error", | ||
| "@typescript-eslint/explicit-function-return-type": "error", | ||
| "@typescript-eslint/consistent-type-assertions": [ | ||
| "error", | ||
| { "assertionStyle": "never" } | ||
| ], | ||
| "@typescript-eslint/explicit-member-accessibility": [ | ||
| "error", | ||
| { "accessibility": "explicit", "overrides": { "constructors": "off" } } | ||
| ], | ||
| "@typescript-eslint/member-ordering": "error" | ||
| } | ||
| ``` | ||
|
|
||
| 5. (+16) ESLint configuration file must be configured with [`typescript-eslint`](https://typescript-eslint.io/) (with enabled [type checking rules](https://typescript-eslint.io/getting-started/typed-linting/)), [`eslint-config-airbnb-typescript`](https://www.npmjs.com/package/eslint-config-airbnb-typescript), [`eslint-config-prettier`](https://github.com/prettier/eslint-config-prettier) (do not confuse it with `eslint-plugin-prettier`. it is [not recommended](https://prettier.io/docs/en/integrating-with-linters.html#:~:text=generally%20not%20recommended) by the prettier documentation.) and the necessary dependencies for them to work. | ||
| - _With the mentor's permission, it is acceptable to disable or tweak some rules (e.g. `import/prefer-default-export`, `no-underscore-dangle`, etc.) as long as it does not conflict with penalties._ | ||
| - _It is allowed to tweak the config to be stricter to make your code even cleaner (according to your or your mentor's preference)._ |
There was a problem hiding this comment.
Here's the thing:
eslint-config-airbnb-base and eslint-config-airbnb-typescript look outdated at the moment (have not been updated to ESLint v9).
A possible solution is to remove airbnb from the requirements and add a list of important good eslint rules, but I need help with a list of such rules.
There was a problem hiding this comment.
I could suggest https://www.npmjs.com/package/eslint-plugin-unicorn instead.
Typescript-eslint itself uses it for their code https://github.com/typescript-eslint/typescript-eslint/blob/main/eslint.config.mjs
EternalRival
commented
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2024Q4] Decision Making Tool
🤔 This is a ...
Description
Additional Information
Checklist