Skip to content

[2024Q4] Decision Making Tool #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 13, 2025

Conversation

EternalRival
Copy link
Contributor

@EternalRival EternalRival commented Oct 18, 2024

[2024Q4] Decision Making Tool

🤔 This is a ...

  • 🌟 New task
  • 🌐 New module
  • ⚙️ Update to an existing task
  • 🔧 Update to an existing module
  • 🔗 Update or addition of external resources or links
  • 🐛 Fix in a task or related content
  • 🛠 Fix in a module or related content
  • ✏️ Fixed a typo or grammatical error
  • 🔗 Fixed a broken link
  • ❓ Other (specify: ****____****)

Description

  • Brief Overview: Add a task "Decision Making Tool"
  • Implementation Approach: ---

Additional Information

  • Screenshots/Links:

dmt-preview

  • Related Issues:

Checklist

  • ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

@EternalRival EternalRival changed the title [2024Q4] Wheel of Fortune [2024Q4] Decision Making Tool Nov 22, 2024
@EternalRival EternalRival marked this pull request as draft November 27, 2024 16:57
@WiiJoy WiiJoy marked this pull request as ready for review February 6, 2025 09:39

### Code Quality (80 points)

> The use of innerHTML is prohibited. Use of DOM search methods is prohibited. ([there are good reasons for not using them](https://gist.github.com/TELEUZI/410d19772481d98b06e0b41ebf89fff1#naive-implementation-).)
Copy link
Contributor Author

@EternalRival EternalRival Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the penalties section these methods are mentioned like this:

(querySelector*, getElement*, etc.)

If you don't mind, help me to correct that part here in the requirements and penalties

@EternalRival EternalRival requested a review from TELEUZI February 8, 2025 14:14
@WiiJoy WiiJoy merged commit 71d16aa into rolling-scopes-school:master Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants