Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: oxc v0.38.0 #2925

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore: oxc v0.38.0 #2925

merged 1 commit into from
Nov 26, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 26, 2024

No description provided.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 75858f6
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6745796aea98870008f9a866

@Boshen
Copy link
Member Author

Boshen commented Nov 26, 2024

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@babel/runtime' imported from /Users/boshen/github/rolldown/crates/rolldown/tests/esbuild/lower/lower_nullish_coalescing_assignment_issue1493/dist/entry.js

How and where should we bundle this helper? We use babel runtime for the time being but will eventually switch to our own helper oxc-project/oxc#7422

@hyf0
Copy link
Member

hyf0 commented Nov 26, 2024

@Boshen It's tricky here. When you use bable in webpack/rollup, it's your job to install @babel/runtime. But oxc in rolldown is a bit like a builtin thing, probably should add it in the deps I guess.

@Boshen Boshen marked this pull request as draft November 26, 2024 06:04
Copy link

github-actions bot commented Nov 26, 2024

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.02     73.6±3.64ms        ? ?/sec    1.00     72.1±0.92ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     98.0±1.39ms        ? ?/sec    1.01     98.6±1.87ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    112.3±1.40ms        ? ?/sec    1.01    113.1±1.02ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     80.7±0.73ms        ? ?/sec    1.00     80.9±0.86ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    124.2±1.33ms        ? ?/sec    1.01    125.7±1.24ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    217.7±1.96ms        ? ?/sec    1.02    222.2±1.73ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    258.4±2.52ms        ? ?/sec    1.01    261.1±2.14ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    138.6±1.43ms        ? ?/sec    1.01    140.6±5.45ms        ? ?/sec
bundle/bundle@threejs                                               1.01     37.3±2.33ms        ? ?/sec    1.00     37.0±1.28ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     93.6±1.22ms        ? ?/sec    1.01     95.0±1.22ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    110.3±1.96ms        ? ?/sec    1.00    110.8±1.19ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.1±0.50ms        ? ?/sec    1.02     47.9±0.28ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00   406.3±13.20ms        ? ?/sec    1.00    407.3±3.10ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1219.6±5.37ms        ? ?/sec    1.01   1233.6±7.61ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1430.5±5.73ms        ? ?/sec    1.01   1443.6±6.91ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    474.9±3.82ms        ? ?/sec    1.01    478.5±2.96ms        ? ?/sec
remapping/remapping                                                 1.01     27.7±0.38ms        ? ?/sec    1.00     27.3±0.13ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     75.0±0.49ms        ? ?/sec    1.00     75.1±0.38ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    100.7±1.41ms        ? ?/sec    1.01    102.1±1.58ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.2±1.08ms        ? ?/sec    1.01     28.4±1.02ms        ? ?/sec
scan/scan@threejs10x                                                1.00    292.4±3.13ms        ? ?/sec    1.00    292.6±2.56ms        ? ?/sec

packages/rolldown/src/binding.d.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
crates/rolldown/src/ast_scanner/mod.rs Outdated Show resolved Hide resolved
@hyf0
Copy link
Member

hyf0 commented Nov 26, 2024

Need just lint-rust to catch lint errors.

@IWANABETHATGUY IWANABETHATGUY added the autofix.ci Apply autofix.ci on PR label Nov 26, 2024
@github-actions github-actions bot removed the autofix.ci Apply autofix.ci on PR label Nov 26, 2024
@Boshen Boshen marked this pull request as ready for review November 26, 2024 07:33
@hyf0 hyf0 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit a3bcb91 Nov 26, 2024
23 checks passed
@hyf0 hyf0 deleted the oxc-0.38.0 branch November 26, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants