Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added telemetry support #160

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added telemetry support #160

wants to merge 5 commits into from

Conversation

danielmorell
Copy link
Collaborator

@danielmorell danielmorell commented Jan 17, 2025

Description of the change

This PR adds support for telemetry to the Laravel package. There are a few notable items in this PR:

  • This will be releases as a beta version since it depends on the Rollbar PHP core SDK v4.1.0-rc. Once the stable version of v4.1 is released we will put out a stable release of this package.
  • I updated how we handle configs to better support the additional configs for telemetry.
  • The test suite was not being run in CI and needed some updates, in addition of telemetry tests.

This adds telemetry for three Laravel events to start with. We can add more as we see what is useful to the community. Each event type can be enabled or disabled individually. The events are:

  • MessageLogged.
  • RouteMatched.
  • QueryExecuted.

The commit 6a456ae message should have been "Added tests for telemetry." 🤦

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component. label Jan 17, 2025
@danielmorell danielmorell added this to the v8.1.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry support
1 participant