Skip to content

Commit

Permalink
Merge pull request #468 from rollbar/added/custom-host-setting
Browse files Browse the repository at this point in the history
Issue #316 Added support for host override setting.
  • Loading branch information
danielmorell authored Jan 19, 2025
2 parents 8805c6f + 2a3b657 commit be4fdac
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion rollbar/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ def _get_fastapi_request():
'environment': 'production',
'exception_level_filters': [],
'root': None, # root path to your code
'host': None, # custom hostname of the current host
'branch': None, # git branch name
'code_version': None,
# 'blocking', 'thread' (default), 'async', 'agent', 'tornado', 'gae', 'twisted', 'httpx' or 'thread_pool'
Expand Down Expand Up @@ -1447,8 +1448,9 @@ def _build_server_data():
Returns a dictionary containing information about the server environment.
"""
# server environment
host = SETTINGS.get('host') or socket.gethostname()
server_data = {
'host': socket.gethostname(),
'host': host,
'pid': os.getpid()
}

Expand Down
4 changes: 3 additions & 1 deletion rollbar/test/test_rollbar.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,16 @@ def test_server_data(self):
self.assertIn('argv', server_data)
self.assertNotIn('branch', server_data)
self.assertNotIn('root', server_data)
self.assertGreater(len(server_data['host']), 2)

rollbar.SETTINGS['host'] = 'test-host'
rollbar.SETTINGS['branch'] = 'master'
rollbar.SETTINGS['root'] = '/home/test/'

server_data = rollbar._build_server_data()

self.assertIn('host', server_data)
self.assertIn('argv', server_data)
self.assertEqual(server_data['host'], 'test-host')
self.assertEqual(server_data['branch'], 'master')
self.assertEqual(server_data['root'], '/home/test/')

Expand Down

0 comments on commit be4fdac

Please sign in to comment.