Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested assertions causing compilation error when using sub _ #314

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Fix nested assertions causing compilation error when using sub _ #314

merged 3 commits into from
Feb 10, 2025

Conversation

luis-j-soares
Copy link
Contributor

Fixes #313

  • Updated the logic in modifyAssertions to recursively walk up to the first ancestor FunctionExpression
  • Updated unit tests

TwitchBronBron
TwitchBronBron approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@TwitchBronBron TwitchBronBron merged commit cf8b251 into rokucommunity:master Feb 10, 2025
3 checks passed
@luis-j-soares luis-j-soares deleted the fix/return-invalid-on-nested-blocks-in-sub branch February 10, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested assertions cause compilation error when using sub _
2 participants
@luis-j-soares @TwitchBronBron