Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/update framework folder to match structure on device #306

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Task/update framework folder to match structure on device #306

merged 6 commits into from
Jan 28, 2025

Conversation

chrisdp
Copy link
Collaborator

@chrisdp chrisdp commented Jan 15, 2025 •
edited
Loading

Simplify the framework file handling.

  • move files in the ./framework folder to their correct nested locations (i.e. inside the rooibos subfolder) to match structure on device.
  • update the plugin to load all framework files from that folder rather than maintaining a curated list.
  • remove frameworkSourcePath option from FileFactory entirely because the framework file locations are not customizable ore replaceable (rooibos depends on these exact framework files).

@chrisdp chrisdp marked this pull request as ready for review January 15, 2025 16:28
@chrisdp chrisdp added the enhancement New feature or request label Jan 15, 2025
TwitchBronBron
TwitchBronBron approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks good to me.

@TwitchBronBron TwitchBronBron merged commit f60e0a9 into master Jan 28, 2025
6 checks passed
@TwitchBronBron TwitchBronBron deleted the task/update-framework-folder-to-match-structure-on-device branch January 28, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

@markwpearce markwpearce Awaiting requested review from markwpearce

@georgejecook georgejecook Awaiting requested review from georgejecook

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdp @TwitchBronBron