Support for type aliases #77

ijc · 2018-03-16T14:50:42Z

Fixes #71 and supercedes #69. Handles the case described in #69 (comment), i.e.

$ cat <<EOF | ./godef -i -o 106
package main
import "encoding/json"
func xxxx() {
    type foo = json.Encoder
    x := new(foo)
    _ = x.Encode
}
EOF
/usr/lib/go-1.10/src/encoding/json/stream.go:195:21

i.e. it correctly finds the definition of x.Encode (offset 106 is on the E)

Also:

$ cat <<EOF | ./godef -i -o 91
package main
import "encoding/json"
func xxxx() {
    type foo = json.Encoder
    x := new(foo)
    _ = x.Encode
}
EOF

4:10

Where offset 91 is the f in new(foo) and 4:10 is the json.Encoder

lawrsp · 2018-03-22T07:24:53Z

go/types/types.go

+		return false
+	}
+	ts, ok := obj.Decl.(*ast.TypeSpec)
+	return ok && ts.Assign != 0


maybe should use IsValid() method:

return ok && ts.Assign.IsValid()

Thanks, I agree, will push an updated commit.

lawrsp · 2018-03-22T19:58:38Z

go/parser/parser.go

@@ -2027,8 +2027,12 @@ func parseTypeSpec(p *parser, doc *ast.CommentGroup, decl *ast.GenDecl, _ int) a
 	// at the identifier in the TypeSpec and ends at the end of the innermost
 	// containing block.
 	// (Global identifiers are resolved in a separate phase after parsing.)
-	spec := &ast.TypeSpec{doc, ident, nil, p.lineComment}
+	spec := &ast.TypeSpec{doc, ident, 0, nil, p.lineComment}


maybe use token.NoPos ?

spec := &ast.TypeSpec{doc, ident, token.NoPos, nil, p.lineComment}

Good point, done.

lawrsp · 2018-03-22T20:06:51Z

go/parser/parser.go

@@ -2027,8 +2027,12 @@ func parseTypeSpec(p *parser, doc *ast.CommentGroup, decl *ast.GenDecl, _ int) a
 	// at the identifier in the TypeSpec and ends at the end of the innermost
 	// containing block.
 	// (Global identifiers are resolved in a separate phase after parsing.)
-	spec := &ast.TypeSpec{doc, ident, nil, p.lineComment}
+	spec := &ast.TypeSpec{doc, ident, 0, nil, p.lineComment}


this is not enough, should add some line to parse rightly

+ spec := &ast.TypeSpec{doc, ident, token.NoPos, nil, p.lineComment} p.declare(spec, p.topScope, ast.Typ, ident) + if p.tok == token.ASSIGN { + spec.Assign = p.pos + p.next() + }

I must be missing something, apart from the token.NoPos change (which I've just made), your proposal looks identical to what is already there to me.

my fault, confused with the pull-request page ;)

Fixes rogpeppe#71 and supercedes rogpeppe#69. Handles the case described in rogpeppe#69 (comment), i.e. ``` $ cat <<EOF | ./godef -i -o 106 package main import "encoding/json" func xxxx() { type foo = json.Encoder x := new(foo) _ = x.Encode } EOF /usr/lib/go-1.10/src/encoding/json/stream.go:195:21 ``` i.e. it correctly finds the definition of `x.Encode` (offset 106 is on the `E`) Also: ``` $ cat <<EOF | ./godef -i -o 91 package main import "encoding/json" func xxxx() { type foo = json.Encoder x := new(foo) _ = x.Encode } EOF 4:10 ``` Where offset 91 is the `f` in `new(foo)` and `4:10` is the `json.Encoder`

ijc · 2018-04-03T16:24:50Z

@rogpeppe any thoughts on this one?

chessman · 2018-05-02T09:52:58Z

I've been testing this PR for a month and it works perfectly.

Asarew · 2018-05-24T08:46:46Z

@rogpeppe I've been running this fix for a while now and everything seems to be good! Do you have any input on this PR?

marwan-at-work · 2018-06-26T22:32:46Z

@Asarew Should this repo be officially forked? Seems like @rogpeppe is unresponsive and this tool is much faster to work with on vscode than other ones :)

Asarew · 2018-06-27T20:45:30Z

Based on the amount of activity in this repo from @rogpeppe; I would agree. But I think that "just" making a fork wouldn't help the community in the long run. Perhaps something like a public notice first, where we would impose a discussion about the future of this project. This is not only for the go community, but also for @rogpeppe. There are a couple of issues open which are not that difficult to solve and are critical to the usability of this tool (eq: #77, #83). I hope that enough gophers in the vscode user-base agree with your statement, and are willing to invest some time in the survival of this project.

@marwan-at-work what do you think? If you agree I will draft a notice, create a new issue, and make an attempt to get some public attention.

Asarew · 2018-06-28T13:16:51Z

If there are no objections from the participants in this issue by Monday 12:00(GMT+2), I will move ahead with creating the public notice. And also propose a timeline which will include merging this pull request.

uudashr · 2018-07-27T19:01:11Z

@rogpeppe should me move forward on this PR? I think PR should works. Some of the functionality on vscode-go depends on this

uudashr · 2018-08-10T03:49:17Z

@rogpeppe kindly need your help on this

Asarew · 2018-08-10T10:23:10Z

I have teamed up with the Gofrs to help out @rogpeppe maintain and update this community wide used project. See issue #86 to follow the discussion.

uudashr · 2018-09-10T07:30:33Z

Hi @rogpeppe, we are still waiting for this PR.
On vscode-go, for some project that has dependencies use alias, the definition are broken causing hovering info doesn't shown. I've seen that this PR solve the issues.

rogpeppe

LGTM, thanks. And abject apologies for leaving this so long. It could use a test in go/types/types_test.go but I can add that.

ijc · 2018-09-12T13:26:39Z

Thanks @rogpeppe and welcome back!

GerryG · 2018-09-30T19:09:29Z

I tend to doubt it. I seem to have this same problem, and I checked that the Merge above in in my workspace for godef

GerryG · 2018-09-30T19:12:06Z

I take that back. I installed the version built from that code and it seems to have fixed it.

In case the use case matters to anyone. I was using godef from GoClipse

lawrsp reviewed Mar 22, 2018

View reviewed changes

ijc force-pushed the type-aliases branch from 3254d93 to 099489e Compare March 22, 2018 10:00

lawrsp reviewed Mar 22, 2018

View reviewed changes

ijc force-pushed the type-aliases branch from 099489e to 8faf556 Compare March 23, 2018 10:07

Asarew mentioned this pull request Aug 6, 2018

Godef gofrs/help-requests#8

Closed

rogpeppe approved these changes Sep 11, 2018

View reviewed changes

rogpeppe merged commit 8312188 into rogpeppe:master Sep 11, 2018

rogpeppe mentioned this pull request Sep 11, 2018

go/parser: support type alias #69

Closed

ijc deleted the type-aliases branch September 12, 2018 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for type aliases #77

Support for type aliases #77

ijc commented Mar 16, 2018

lawrsp Mar 22, 2018

ijc Mar 22, 2018

lawrsp Mar 22, 2018

ijc Mar 23, 2018

lawrsp Mar 22, 2018

ijc Mar 23, 2018

lawrsp Mar 23, 2018

ijc commented Apr 3, 2018

chessman commented May 2, 2018

Asarew commented May 24, 2018

marwan-at-work commented Jun 26, 2018 •

edited

Loading

Asarew commented Jun 27, 2018 •

edited

Loading

Asarew commented Jun 28, 2018 •

edited

Loading

uudashr commented Jul 27, 2018 •

edited

Loading

uudashr commented Aug 10, 2018

Asarew commented Aug 10, 2018 •

edited

Loading

uudashr commented Sep 10, 2018

rogpeppe left a comment

ijc commented Sep 12, 2018

GerryG commented Sep 30, 2018

GerryG commented Sep 30, 2018 •

edited

Loading

Support for type aliases #77

Support for type aliases #77

Conversation

ijc commented Mar 16, 2018

lawrsp Mar 22, 2018

Choose a reason for hiding this comment

ijc Mar 22, 2018

Choose a reason for hiding this comment

lawrsp Mar 22, 2018

Choose a reason for hiding this comment

ijc Mar 23, 2018

Choose a reason for hiding this comment

lawrsp Mar 22, 2018

Choose a reason for hiding this comment

ijc Mar 23, 2018

Choose a reason for hiding this comment

lawrsp Mar 23, 2018

Choose a reason for hiding this comment

ijc commented Apr 3, 2018

chessman commented May 2, 2018

Asarew commented May 24, 2018

marwan-at-work commented Jun 26, 2018 • edited Loading

Asarew commented Jun 27, 2018 • edited Loading

Asarew commented Jun 28, 2018 • edited Loading

uudashr commented Jul 27, 2018 • edited Loading

uudashr commented Aug 10, 2018

Asarew commented Aug 10, 2018 • edited Loading

uudashr commented Sep 10, 2018

rogpeppe left a comment

Choose a reason for hiding this comment

ijc commented Sep 12, 2018

GerryG commented Sep 30, 2018

GerryG commented Sep 30, 2018 • edited Loading

marwan-at-work commented Jun 26, 2018 •

edited

Loading

Asarew commented Jun 27, 2018 •

edited

Loading

Asarew commented Jun 28, 2018 •

edited

Loading

uudashr commented Jul 27, 2018 •

edited

Loading

Asarew commented Aug 10, 2018 •

edited

Loading

GerryG commented Sep 30, 2018 •

edited

Loading