Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix edge case for #9 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Fix edge case for #9 #10

wants to merge 1 commit into from

Conversation

joyarzun
Copy link
Collaborator

@joyarzun joyarzun commented Dec 5, 2016

This will resolve #9

@pamo
Copy link
Collaborator

pamo commented Dec 5, 2016

Came to say this but then I noticed WIP.

  20 passing (42ms)
  1 failing

  1) parser different AMD patterns parses anonymous modules with star:
     AssertionError: expected '\n  define([\'dep1\', \'example\', // requirejs_plugin|*| \'dep2\'], function (dep1, dep2) {\n      return function () {};\n  });\n' to match /example', \/\/ requirejs_plugin\|args\|/
      at Context.it (test/parser.spec.js:65:73)

@joyarzun
Copy link
Collaborator Author

joyarzun commented Dec 6, 2016

Yep, It's just a test. If broken the CI then we are happy :p
Broken driven development ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge case for define format
2 participants