Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin manager improvements #278

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Conversation

zonical
Copy link
Collaborator

@zonical zonical commented Jan 20, 2024

A few additions after a conversation on Discord:

  • Updated comments for AddPlayerToGroup
  • Added player controller equivalent for GetPlayerAdminData and RemovePlayerAdminData
  • Added GetPlayerImmunity
  • Prevent HLTV player controller from being passed into admin-related functions
  • Changed TargetType.GroupAll TargetPredicate to exclude HLTV

I've decided to exclude the HLTV player from these functions as they do not have a physical presence in the world and shouldn't be manipulated with commands.

zonical and others added 2 commits January 21, 2024 09:25
…r GetPlayerAdminData and RemovePlayerAdminData, add GetPlayerImmunity, add checks for player.IsHLTV, change TargetType.GroupAll TargetPredicate to exclude HLTV (but include everyone else)
B3none
B3none previously approved these changes Jan 20, 2024
Copy link
Collaborator

@B3none B3none left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it maintains backwards compatibility. LGTM 👍

@B3none B3none changed the base branch from main to v149-development January 21, 2024 00:09
@B3none B3none changed the base branch from v149-development to main January 21, 2024 00:10
@B3none B3none dismissed their stale review January 21, 2024 00:10

The base branch was changed.

@B3none B3none changed the base branch from main to v149-development January 21, 2024 01:31
@B3none B3none merged commit 803b6b3 into roflmuffin:v149-development Jan 21, 2024
4 checks passed
roflmuffin pushed a commit that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants