Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add lua lint check #149

Closed
wants to merge 4 commits into from
Closed

CI: add lua lint check #149

wants to merge 4 commits into from

Conversation

lelutin
Copy link
Collaborator

@lelutin lelutin commented Aug 28, 2024

We now have our first lua script so we should start checking that for obvious problems

I'll run each change to the CI here by pushing individual commits. That'll let me verify whether the changes are working or not.

@lelutin lelutin force-pushed the ci_rework branch 3 times, most recently from a8e68d0 to f2a30d2 Compare August 28, 2024 23:52
Currently the test matrix diplays `tests (true`) and `tests (false)`.
This is not super informative and if forces one to dive into the
workflows file to figure out what it means.

With more descriptive names, the purpose of each test becomes more
apparent. Here we're using the value that we need to give to the TESTVIM
env variable when we run the vader test suite.
@lelutin lelutin force-pushed the ci_rework branch 4 times, most recently from 3318385 to 0e2cd3f Compare August 29, 2024 01:41
We now have our first lua script so we should start checking that for
obvious problems
@lelutin
Copy link
Collaborator Author

lelutin commented Aug 29, 2024

all done with this. I've merged the changes with an amend on the last commit so github won't identify that it was merged.

@lelutin lelutin closed this Aug 29, 2024
@lelutin lelutin deleted the ci_rework branch August 29, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant