Consistent Column count with null values across resultset #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2018 00:53
ktordoff13
reviewed
Jan 28, 2020
| @@ -35,7 +41,7 @@ function Sybase(host, port, dbname, username, password, logTiming, pathToJavaBri | |||
| Sybase.prototype.connect = function(callback) | |||
| { | |||
| var that = this; | |||
| this.javaDB = spawn('java',["-jar",this.pathToJavaBridge, this.host, this.port, this.dbname, this.username, this.password]); | |||
| this.javaDB = spawn('java',["-jar",this.pathToJavaBridge, this.host, this.port, this.dbname, this.username, this.password, this.allowNull]); | |||
There was a problem hiding this comment.
I am getting an error when allowNull is set to true
Error: Expecting the arguments: host, port, dbname, username, password
|
Hi! This repo is no longer maintained (nobody here has access to a Sybase instance to test it anymore), so I'm afraid this is pretty unlikely to get merged. |
I'm having this same problem, can anyone accept the pull request? can i help to test |
|
I am having the same problem. This is a big show stopper. |
|
If anyone is ready to accept this, I can rebase and resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference: #25
Description:
The previous version was ignoring the columns having
nullvalues for any records at any position.allowNullas an optional parameter to includenullvalued columns in the response JSON for maintaining the consistent column count across rows. If not passed, then the driver will work as earlier. No need to change anything, already backward compatible.TODOs: