-
Notifications
You must be signed in to change notification settings - Fork 220
chore: update mlkit and react-native-vision-camera dependencies #58
base: master
Are you sure you want to change the base?
Conversation
nice @nachozullo this PR looks so well, i'll try late cause we have the same problem in our app. Thanks |
Hi @nachozullo, thanks for this PR and time invested in the project, i'm surprised that this project is working for you guys, i checked that PR and i'm facing the same issue that i had in master, that seems to be related to the reanimated lib, the app just crash instantly |
Hello @rodgomesc look like the example from the main repo it's broken, i'll be try to fix it in this PR. |
@nachozullo you was able to successfully build the example app in this repo? |
Hi everyone. In our team we need this changes too. I checked and the example app crashes before @nachozullo changes. There is a pull request to fix that #66, but it will be great to merge this PR asap. Thanks for the library and the fix! |
@rodgomesc Would you merge this ? Otherwise i should patch this lib |
Hello @rodgomesc,
We are currently working with this library in our app. Since the last update from one of our local dependency, which use the latest version of
com.google.mlkit:barcode-scanning
, the vision-camera-code-scanner library is not working on Android because the path where Barcode reference is located are different between versions.In this PR I change all Barcode references and update the
com.google.mlkit:barcode-scanning
dependency. After that all start working again. I think that this is maybe a breaking change if you are using another library withcom.google.mlkit:barcode-scanning
as a dependency with a minor version but I tested and all appear to be working well.Best regards.