Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Android fix - App crash on barcode read. #138

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Android fix - App crash on barcode read. #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0737b80
Android fixes
kheuser Mar 22, 2023
2183175
Mentioned forked repo on readme
kheuser Mar 22, 2023
54c0f6b
Reverted Readme
kheuser Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,5 @@ dependencies {
implementation "com.facebook.react:react-native:+" // From node_modules
api project(":react-native-vision-camera")
implementation "androidx.camera:camera-core:1.1.0-alpha06"
implementation 'com.google.mlkit:barcode-scanning:17.0.0'
implementation 'com.google.mlkit:barcode-scanning:17.0.2'
}
2 changes: 1 addition & 1 deletion android/src/main/java/com/visioncameracodescanner/BarcodeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import com.facebook.react.bridge.WritableNativeArray;
import com.facebook.react.bridge.WritableNativeMap;
import com.google.mlkit.vision.barcode.Barcode;
import com.google.mlkit.vision.barcode.common.Barcode;

import java.util.List;

Expand Down
14 changes: 7 additions & 7 deletions android/src/main/java/com/visioncameracodescanner/VisionCameraCodeScannerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import com.google.android.gms.tasks.Tasks;
import com.mrousavy.camera.frameprocessor.FrameProcessorPlugin;
import com.google.android.gms.tasks.Task;
import com.google.mlkit.vision.barcode.Barcode;
import com.google.mlkit.vision.barcode.common.Barcode;
import com.google.mlkit.vision.barcode.BarcodeScanner;
import com.google.mlkit.vision.barcode.BarcodeScanning;
import com.google.mlkit.vision.barcode.BarcodeScannerOptions;
Expand Down Expand Up @@ -219,17 +219,17 @@ private WritableNativeMap convertBarcode(@NonNull Barcode barcode) {

// Bitmap Inversion https://gist.github.com/moneytoo/87e3772c821cb1e86415
private Bitmap invert(Bitmap src)
{
{
int height = src.getHeight();
int width = src.getWidth();
int width = src.getWidth();

Bitmap bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888);
Canvas canvas = new Canvas(bitmap);
Paint paint = new Paint();

ColorMatrix matrixGrayscale = new ColorMatrix();
matrixGrayscale.setSaturation(0);

ColorMatrix matrixInvert = new ColorMatrix();
matrixInvert.set(new float[]
{
Expand All @@ -239,10 +239,10 @@ private Bitmap invert(Bitmap src)
0.0f, 0.0f, 0.0f, 1.0f, 0.0f
});
matrixInvert.preConcat(matrixGrayscale);

ColorMatrixColorFilter filter = new ColorMatrixColorFilter(matrixInvert);
paint.setColorFilter(filter);

canvas.drawBitmap(src, 0, 0, paint);
return bitmap;
}
Expand Down