Fix: Support 1PIF file format for 1Password v7.9.11 (macOS) #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule out CSV file format when a data line looks like json formatted line
With 1Password 7.9.11, pass-import erroneous detects a 1PIF file as a CSV file. This PR improves the CSV detection capability by checking if the CSV file look like a valid JSON file. IFF it does, then the file is not considered a CSV file.
Removed empty line when reading 1PIF file
1PIF exported from 1Password 7.9.11 contains an extra empty line at the end of the file. This empty line is now removed.
Encoded special characters properly when reading JSON strings
1PIF exported from 1Password 7.9.11 does not encode special character. These characters are now properly encoded.
PS: thank you for starting this project and help reduce vendor lock-in. 1Password :-(