Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define NoDup_dec with Defined instead of Qed #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olympichek
Copy link

This pull request will close issue #125

@proux01
Copy link
Contributor

proux01 commented Apr 8, 2025

@rocq-prover/stdlib-maintainers could anyone have a look please (I'm not qualified myself about those transparencies questions, their impact in terms of performances,...)

@ppedrot
Copy link
Member

ppedrot commented Apr 8, 2025

I think this is a very bad idea. It exposes bits of proofs constructed via tactics and that's a big no-no. Furthermore it's probably not usable in practice due to these huge proof terms creeping in.

Across the decades we've been taking nonsense design decisions in the stdlib out of inertia, but the proper way to do this is to write a decision function returning a boolean and prove that indeed it reflects the predicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants