Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elastic version to software install #502

Closed
wants to merge 2 commits into from

Conversation

jokvedaras
Copy link
Contributor

Previous logic did not allow for user to install a specific version of elastic. Updated per #497

@jokvedaras jokvedaras changed the title Elastic version Add Elastic version to software install Oct 7, 2019
Copy link
Member

@dcode dcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I see how this logic is any different. The default suffix is "x", which means "7.x" will be installed. If you wanted to stay on 7.4, you would change the suffix to "4.x", which would then set the Elastic version to "7.4.x". I guess line 114 does need to change as you've indicated to make that work though.

Can you revert the other lines or explain how that doesn't work?

@jokvedaras
Copy link
Contributor Author

In your current baseline, if you set suffix, elastic_baseurl get updated as you said. From my testing, the only acceptable value for elastic_baseurl is https://artifacts.elastic.co/packages/{{ elastic.major_version }}.x/yum. Updating to 7.4 or similar is not a valid URL.

The only reason why you would be interested in this pull request is if you want to have more control over the elastic versions you are installing. I have to use an approved version of elastic hence I had to add this logic in my fork.

@jokvedaras jokvedaras closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants