Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 fixed outdated and hardcoded value in stake rpl #649

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

thomaspanf
Copy link
Member

This PR fixes a message in stake-rpl that was outdated and hardcoded

Old:

Are you sure you want to stake 543.482558 RPL? You will not be able to unstake this RPL until you exit your validators and close your minipools, or reach over 100% collateral! [y/n]

New:

Are you sure you want to stake 543.482558 RPL? You will not be able to unstake this RPL until you exit your validators and close your minipools, or reach 1086.965117 staked RPL (60% of bonded eth)! [y/n]

Copy link

Coverage Report

Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node 0.01% (ø)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/node 0.00% (ø)
github.com/rocket-pool/smartnode/v2/shared/types/api 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node/stake-rpl.go 0.00% (ø) 520 0 520
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/node/stake-rpl.go 0.00% (ø) 295 (+54) 0 295 (+54)
github.com/rocket-pool/smartnode/v2/shared/types/api/node.go 0.00% (ø) 184 0 184

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax 0xfornax merged commit 4b63eab into v2 Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants