Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate empty data field #645

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Populate empty data field #645

merged 1 commit into from
Sep 9, 2024

Conversation

thomaspanf
Copy link
Member

Fix for this segfault.

~ $ rocketpool m rd

This command will allow you to manually deposit the remaining ETH for any dissolved minipools, activating them so you can exit them and retrieve your minipool's funds.
Please read our guide at https://docs.rocketpool.net/guides/node/rescue-dissolved.html to fully read about the process before continuing.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5c4458]

goroutine 1 [running]:
math/big.(*Int).Cmp(0x4040000000000000?, 0x109f874?)
    math/big/int.go:381 +0x18
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/minipool.rescueDissolved(0xc0005b4ec0)
    github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/minipool/rescue-dissolved.go:77 +0x539
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/minipool.RegisterCommands.func16(0xc0005b4ec0)
[9:24 PM]

Copy link

github-actions bot commented Sep 9, 2024

Coverage Report

Copy link

github-actions bot commented Sep 9, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/minipool 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/minipool/rescue-dissolved-details.go 0.00% (ø) 287 0 287

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax 0xfornax merged commit 2d0d99b into v2 Sep 9, 2024
8 checks passed
@0xfornax 0xfornax deleted the v2-rescue-dissolved-segfault branch September 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants