Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed segfault by populating nil pointer #644

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fixed segfault by populating nil pointer #644

merged 1 commit into from
Sep 4, 2024

Conversation

thomaspanf
Copy link
Member

Addresses #634

rp-cli segfaults here becauserp-daemon never populates response.Data.RplStake

Copy link

github-actions bot commented Sep 3, 2024

Coverage Report

Copy link

github-actions bot commented Sep 3, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/node 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/node/set-rpl-withdrawal-address.go 0.00% (ø) 181 (+8) 0 181 (+8)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Copy link
Contributor

@jshufro jshufro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasingly disenchanted with the framework. This landmine keeps coming up.

@0xfornax 0xfornax merged commit 0fb3e6f into v2 Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants