generated from devcontainers/feature-starter
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(r-dependent-packages): new feature r-dependent-packages
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
force-pushed
the
r-packages-from-desc
branch
from
May 10, 2024 03:36
c86d09c
to
010f457
Compare
eitsupi
force-pushed
the
r-packages-from-desc
branch
from
May 12, 2024 04:52
a8a3e57
to
930dda6
Compare
eitsupi
force-pushed
the
r-packages-from-desc
branch
from
May 12, 2024 05:39
66f9cf3
to
5c44688
Compare
This comment was marked as outdated.
This comment was marked as outdated.
eitsupi
changed the title
feat(r-dependent-packages): add a new feature
feat(r-dependent-packages): new feature May 12, 2024
r-dependent-packages
r-dependent-packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #208
@dpprdan Could you take a look at this? (I am convinced that this is the right design, but I am not sure about the name!)
I assume this will be a simple Feature like https://github.com/rocker-org/devcontainer-features/tree/b24eea2adb7eb39260765f8d0e0cbddc65ac5537/src/r-history, just setting the script to the container.
As far as I know, there is a similar functionality in https://github.com/JuliaLang/devcontainer-features/tree/790b5321727e0b8bfe3bd338749978811c64428b/src/julia.
The lifecycle script just check the DESCRIPTION file exists, and execute something like
R -q -e 'pak::pak(NULL, dependencies = "all")'