[miniforge] no fail on existing installation #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
requested changes
Jul 31, 2023
eitsupi
changed the title
|
no problem! thanks for the quick review! |
|
The new release and the new version of the Feature is available. https://github.com/rocker-org/devcontainer-features/releases/tag/feature_miniforge_1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
Note that this does not handle the case where the existing version is not the version requested. I started to address it, but it is made more complicated by the fact that mambaforge versions don't seem to keep up with official conda releases, so I didn't venture further down that path (i.e. if someone comes with an image with a fresh conda install, we would almost certainly be down-grading it here, which might not be desired).
I also updated the devcontainer spec of this repo because it was using an outdated
docker-from-dockerfeature, which in turn made the tests in the tests break when running in the devcontainer.