feat: increase testability #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crocmagnon
force-pushed
the
global-state
branch
from
6127b62 to
3c2ed96
Compare
fsamin
requested changes
Nov 24, 2023
README.md
Outdated
|
|
||
| By default, it is initialized to wrap `logrus` package. You can override `log.Factory` to use the logger library you want. | ||
| By default, it is initialized to wrap `logrus` package. You can use `log.SetFactory` to use the logger library you want. |
There was a problem hiding this comment.
The feature is interesting but the fact that you replace log.Factory by the function log.SetFactory is a breaking change.
Please keep log.Factory as it
Getting rid of global state is a nice step forward in improving testability. Caller code (and more importantly tests) can now fully control the registered fields or the logger used to produce messages. All while not vastly changing the current interface, which keeps the global logging functions it used to have. Those obviously still rely on shared global state.
Crocmagnon
force-pushed
the
global-state
branch
from
3c2ed96 to
0844bd5
Compare
fsamin
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of global state is a nice step forward in improving testability.
Caller code (and more importantly tests) can now fully control the registered fields or the logger used to produce messages.
All while not vastly changing the current interface, which keeps the global logging functions it used to have. Those obviously still rely on shared global state.