Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surround sound support #696

Open
1 of 18 tasks
gavv opened this issue Feb 9, 2024 · 0 comments
Open
1 of 18 tasks

Surround sound support #696

gavv opened this issue Feb 9, 2024 · 0 comments
Labels
enhancement

Comments

@gavv
Copy link
Member

gavv commented Feb 9, 2024 •
edited
Loading

Pipeline

Backends

  • Pulseaudio
    • surround
    • mtr
  • Sndfile:
  • Wav:
    • WavSink: write WAVEX extension header with channel mask
    • WavSink: surround
    • WavSink: mtr
    • WavSource: read channel mask from dr_wav and pass it to ChannelSet
    • WavSource: surround
    • WavSource: mtr

API

TBD

CLI

TBD
@gavv gavv changed the title wav backend surround support Surround & multitrack in backends Feb 10, 2024
@gavv gavv changed the title Surround & multitrack in backends Surround & multitrack & encoding in backends Feb 10, 2024
@gavv gavv changed the title Surround & multitrack & encoding in backends Encodings in backends Feb 10, 2024
@gavv gavv changed the title Encodings in backends Encodings, surround, and mtr in backends Feb 10, 2024
This was referenced Feb 10, 2024
Closed
Closed
@gavv gavv mentioned this issue Mar 4, 2024
Merged
gavv added a commit to gavv/roc-toolkit that referenced this issue Apr 9, 2024
@gavv
roc-streaminggh-696 Add ChannelSet::set_count() and use in sndio back…
2bbbc46 
…ends

To initialize channels in sndio backends, we now use:

    channel_set().set_count(count)

instead of:

    channel_set().set_range(0, count-1)

The new version tries to find a sensible mask for given count.
E.g. for 2 channels, set_range() call above would set FL+FC,
and set_count() would set FL+FR (stereo).

This is an intermediate solution, for appropriate surround support
we'll need to update backends to map channels from file/device
to channel set. set_count() is just a fallback for backends that
don't (yet) have proper support.
gavv added a commit to gavv/roc-toolkit that referenced this issue Apr 9, 2024
@gavv
roc-streaminggh-696 Add ChannelSet::set_count() and use in sndio back…
71b4749 
…ends

To initialize channels in sndio backends, we now use:

    channel_set().set_count(count)

instead of:

    channel_set().set_range(0, count-1)

The new version tries to find a sensible mask for given count.
E.g. for 2 channels, set_range() call above would set FL+FC,
and set_count() would set FL+FR (stereo).

This is an intermediate solution, for appropriate surround support
we'll need to update backends to map channels from file/device
to channel set. set_count() is just a fallback for backends that
don't (yet) have proper support.
@gavv gavv changed the title Encodings, surround, and mtr in backends Surround and MTR in backends Apr 26, 2024
@gavv gavv changed the title Surround and MTR in backends Surround and MTR in sndio backends Apr 26, 2024
@gavv gavv added this to Roc Toolkit Jul 6, 2024
@gavv gavv moved this to Frontlog in Roc Toolkit Jul 6, 2024
@gavv gavv changed the title Surround and MTR in sndio backends Surround and MTR Jul 15, 2024
@gavv gavv changed the title Surround and MTR Surround sound support Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Roc Toolkit
Status: Frontlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavv