Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable encoding (format/rate/channels) #608

Closed
28 tasks done
gavv opened this issue Oct 10, 2023 · 1 comment
Closed
28 tasks done

Configurable encoding (format/rate/channels) #608

gavv opened this issue Oct 10, 2023 · 1 comment
Assignees
@gavv
Labels
c api Task affects public C API enhancement
Milestone
next

Comments

@gavv
Copy link
Member

gavv commented Oct 10, 2023 •
edited
Loading

Allow specifying format/rate/channels of:

  • input frames (sender API)
  • input device (sender CLI)
  • output frames (receiver API)
  • output device (receiver CLI)
  • network packets (sender API, receiver API)
  • network packets (sender CLI, receiver CLI)

Internals:

API:

  • roc_packet_encoding
  • roc_format: native (raw)
  • roc_format: other formats
  • roc_channel_layout: mono, stereo, multitrack
  • roc_media_encoding
  • roc_sender_config: frame_encoding, packet_encoding
  • roc_receiver_config: frame_encoding
  • roc_context_register_encoding

CLI:

  • sample spec parser
  • packet encoding parser
  • remove --rate
  • add --io-encoding SPEC
  • add --packet-encoding ID:SPEC
  • --print-supported
@gavv gavv mentioned this issue Oct 10, 2023
Closed
@gavv gavv added enhancement c api Task affects public C API labels Oct 10, 2023
@gavv gavv self-assigned this Oct 10, 2023
@gavv gavv added this to the next milestone Oct 10, 2023
@gavv gavv mentioned this issue Oct 10, 2023
Closed
24 tasks
@gavv
Copy link
Member Author

gavv commented Oct 10, 2023 •
edited
Loading

@gavv gavv mentioned this issue Nov 14, 2023
Merged
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 16, 2023
@gavv
roc-streaminggh-608 Rework pcm format helpers
d30b4c5
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 17, 2023
@gavv
roc-streaminggh-608 Cleanup pcm funcs
f2b4302
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 17, 2023
@gavv
roc-streaminggh-608 Improve --print-supported
69bcf5c
@gavv gavv modified the milestones: 0.3.0, next Nov 17, 2023
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 19, 2023
@gavv
roc-streaminggh-608 Cleanup pcm funcs
3c66e51
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 19, 2023
@gavv
roc-streaminggh-608 Improve --print-supported
d94f023
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 19, 2023
@gavv
roc-streaminggh-608 Rework pcm format helpers
9015c09
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 19, 2023
@gavv
roc-streaminggh-608 Cleanup pcm funcs
6350940
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 19, 2023
@gavv
roc-streaminggh-608 Improve --print-supported
5ed273f
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 23, 2023
@gavv
roc-streaminggh-608 Cleanup pcm funcs
3eeb949
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 23, 2023
@gavv
roc-streaminggh-608 Improve --print-supported
1d80821
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 25, 2023
@gavv
roc-streaminggh-608 Cleanup pcm funcs
00ceb62
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 25, 2023
@gavv
roc-streaminggh-608 Improve --print-supported
9bd9888
gavv added a commit that referenced this issue Nov 25, 2023
@gavv
gh-608 Fix --print-supported in roc-send
d7c2bcd
gavv added a commit to gavv/roc-toolkit that referenced this issue Nov 29, 2023
@gavv
roc-streaminggh-608 Initial implementation of sample spec parser
8a2c333
gavv added a commit to gavv/roc-toolkit that referenced this issue Jan 30, 2024
@gavv
roc-streaminggh-608 Implement rtp::parse_encoding()
cf74174
@gavv gavv mentioned this issue Mar 4, 2024
Merged
@gavv gavv changed the title Configurable encoding Configurable encoding (format/rate/channels) Apr 26, 2024
@gavv gavv removed this from the 0.4.0 milestone Jun 12, 2024
@gavv gavv added this to the next milestone Jun 12, 2024
gavv added a commit to gavv/roc-toolkit that referenced this issue Jul 6, 2024
@gavv
roc-streaminggh-608: Allow PCM mapping only between raw and non-raw
325b7df 
This commit removes support for direct PCM mapping between
non-raw formats (e.g. int16 <=> int32). Now it's only allowed
to map from raw to non-raw, or vice versa, where "raw" format
is native-endian 32-bit floats.

This change significantly reduces code size (on x86_64/release
.o file is reduced from 5 MB to 80 KB), as well as simplifies
code generator script.

We did not actually use mapping between non-raw formats, except
tests, so the code is mostly unaffected. If we'll need that,
we can create a pair of mappers, first to map input format to
raw format, then to map raw format to output format.

Tests and comments are reworked as well.
gavv added a commit to gavv/roc-toolkit that referenced this issue Jul 6, 2024
@gavv
roc-streaminggh-608: Fix bug in PCM mapper for non-byte aligned formats
a2873e6 
Packer/unpacker for non-byte aligned formats (e.g. 20-bit ints)
had a bug due to a missing type cast.
@gavv gavv added this to Roc Toolkit Jul 6, 2024
@gavv gavv moved this to In work in Roc Toolkit Jul 6, 2024
gavv added a commit to gavv/roc-toolkit that referenced this issue Jul 20, 2024
@gavv
roc-streaminggh-608: Support custom PCM formats in pulseaudio backend
a1d38c2
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
@gavv
roc-streaminggh-608: Support custom PCM formats in sndfile backend
f812c70
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
@gavv
roc-streaminggh-608: Support custom PCM formats in sndfile backend
75d72e8
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 8, 2024
@gavv
roc-streaminggh-608: Support custom PCM formats in sndfile backend
3c8b638
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 8, 2024
@gavv
roc-streaminggh-608: Support custom PCM formats in sndfile backend
c9c0a85
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 20, 2024
@gavv
roc-streaminggh-608: Refine pcm traits
6198f5c 
- introduce "default endian" instead of "native endian"
- replace boolean with flags
- add default/le/ne format variants to traits
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 20, 2024
@gavv
roc-streaminggh-608: Support custom format in wav sink
ed608e1
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 22, 2024
@gavv
roc-streaminggh-608: Refine pcm traits
c5fd1b5 
- introduce "default endian" instead of "native endian"
- replace boolean with flags
- add default/le/ne format variants to traits
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 22, 2024
@gavv
roc-streaminggh-608: Support custom format in wav sink
28b7d36
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 22, 2024
@gavv
roc-streaminggh-608: Disable surround and MTR in CLI
a304d63 
Surround and multitrack layouts will be completed and enabled
in future releases. For now they're hidden from CLI.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 22, 2024
@gavv
[cli] roc-streaminggh-608: Add --io-encoding to all CLI tools
1300dd0
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 22, 2024
@gavv
roc-streaminggh-608: Rework --list-supported
6472e66 
- move to roc_dbgio
- add flags to enable specific sections
- print related cli options
- print pcm formats
- print channel masks
- print fec schemes
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 22, 2024
@gavv
[cli] roc-streaminggh-608: Rework CLI options
b7fb866 
New options:

- Add --packet-encoding to roc-send and roc-recv.
- Add --fec-encoding to roc-send.
- Add --miface to roc-send.

Rename options:

- Rename --nbsrc/--nbrpr to --fec-block-src/--fec-block-rpr.
- Rename --frame-len to --io-frame-len.
- Rename --profile to --prof.

Improvements:

- Group options into sections.
- Update --help messages.

Refactoring:

- Split main() into smaller function.
- Hide sox frame size configuration inside sox backend.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 23, 2024
@gavv
[cli] roc-streaminggh-608: Rework CLI options
96ac193 
New options:

- Add --packet-encoding to roc-send and roc-recv.
- Add --fec-encoding to roc-send.
- Add --miface to roc-send.

Rename options:

- Rename --nbsrc/--nbrpr to --fec-block-src/--fec-block-rpr.
- Rename --frame-len to --io-frame-len.
- Rename --profile to --prof.

Improvements:

- Group options into sections.
- Update --help messages.

Refactoring:

- Split main() into smaller function.
- Hide sox frame size configuration inside sox backend.
gavv added a commit to gavv/roc-toolkit that referenced this issue Sep 11, 2024
@gavv
[wip] [api] [cli] roc-streaminggh-608: Formats and sub-formats
bfbf13f 
API
---

  TODO

CLI
---

  1. --io-encoding option now has form
    <format>@<subformat>/<rate>/<channels>

  E.g.: pcm@s16/44100/stereo
  (whether sub-format is allowed or required depends
   on format)

  2. --input-format/--output-format options are removed,
     their function is now handled by <format> field
     of --io-encoding

  E.g.:
    --output file://- --io-encoding wav@s24/48000/stereo
     or
    --input file://- --io-encoding wav/-/-

  3. --print-supported is updated to discover and list all
     available sub-formats (divided into logical groups).

Docs
----

  TODO

Internals
---------

Introduce concept of format (e.g. PCM, FLAC) and sub-format
(e.g. s16). Support formats and sub-formats in all sndio
backends.

roc_audio:

- SampleFormat => Format
- Formats: Format_Pcm, Format_Wav, Format_Custom
- PcmFormat => PcmSubformat
- SampleSpec: set_format(), set_custom_format(),
  set_pcm_subformat(), set_custom_subformat()
- SampleSpec: is_valid() => is_complete()
- Sample_RawFormat => PcmSubformat_Raw

roc_sndio:

- File formats are now *not* drivers. All file formats
  are handles by special "file://" driver, i.e.
  URI scheme is now always equal to driver.
- Supported file formats and sub-formats are
  discovered from backends separately from drivers.
- For discovery, we use DriverInfo and FormatInfo
  structs.

- IoConfig is empty by default; frame length and latency
  are zero.
- Each backend may use its own defaults for IoConfig.
- We can retrieve actually selected config using
  sample_spec() and frame_length() methods of IDevice.

- SoxBackend: remove file support, allow only devices
  (now we use sndfile for files)
- SoxBackend: support PCM format and sub-formats
- PulseaudioBackend: support PCM format and sub-formats
- SndfileBackend: support formats and sub-formats,
  map to sndfile major type and sub-type
- WavBackend: support WAV format and PCM sub-formats

- Unification of sndio backends
- Bug-fixes in format handling in sndfile backend
gavv added a commit to gavv/roc-toolkit that referenced this issue Sep 11, 2024
@gavv
roc-streaminggh-608: Rename pcm_format to pcm_subformat
1db4d30
gavv added a commit to gavv/roc-toolkit that referenced this issue Sep 11, 2024
@gavv
[wip] [api] [cli] roc-streaminggh-608: Formats and sub-formats
c34cf29 
API
---

  TODO

CLI
---

  1. --io-encoding option now has form
    <format>@<subformat>/<rate>/<channels>

  E.g.: pcm@s16/44100/stereo
  (whether sub-format is allowed or required depends
   on format)

  2. --input-format/--output-format options are removed,
     their function is now handled by <format> field
     of --io-encoding

  E.g.:
    --output file://- --io-encoding wav@s24/48000/stereo
     or
    --input file://- --io-encoding wav/-/-

  3. --print-supported is updated to discover and list all
     available sub-formats (divided into logical groups).

Docs
----

  TODO

Internals
---------

Introduce concept of format (e.g. PCM, FLAC) and sub-format
(e.g. s16). Support formats and sub-formats in all sndio
backends.

roc_audio:

- SampleFormat => Format
- Formats: Format_Pcm, Format_Wav, Format_Custom
- PcmFormat => PcmSubformat
- SampleSpec: set_format(), set_custom_format(),
  set_pcm_subformat(), set_custom_subformat()
- SampleSpec: is_valid() => is_complete()
- Sample_RawFormat => PcmSubformat_Raw

roc_sndio:

- File formats are now *not* drivers. All file formats
  are handles by special "file://" driver, i.e.
  URI scheme is now always equal to driver.
- Supported file formats and sub-formats are
  discovered from backends separately from drivers.
- For discovery, we use DriverInfo and FormatInfo
  structs.

- IoConfig is empty by default; frame length and latency
  are zero.
- Each backend may use its own defaults for IoConfig.
- We can retrieve actually selected config using
  sample_spec() and frame_length() methods of IDevice.

- SoxBackend: remove file support, allow only devices
  (now we use sndfile for files)
- SoxBackend: support PCM format and sub-formats
- PulseaudioBackend: support PCM format and sub-formats
- SndfileBackend: support formats and sub-formats,
  map to sndfile major type and sub-type
- WavBackend: support WAV format and PCM sub-formats

- Unification of sndio backends
- Bug-fixes in format handling in sndfile backend
gavv added a commit to gavv/roc-toolkit that referenced this issue Sep 11, 2024
@gavv
roc-streaminggh-608: Rename pcm_format to pcm_subformat
5b9f12c
gavv added a commit to gavv/roc-toolkit that referenced this issue Sep 11, 2024
@gavv
[api] [cli] roc-streaminggh-608: Formats and sub-formats
544f20e 
API
---

  1. roc_format: the only supported format (currently)
     is now ROC_FORMAT_PCM.

  2. roc_subformat: defines various PCM variants
     (sint, uint, float, endian).

  3. roc_media_encoding: format+subformat define
     sample coding together.

CLI
---

  1. --io-encoding and --packet-encoding options now have form
    <format>[@<subformat>]/<rate>/<channels>

  E.g.: pcm@s16/44100/stereo
  (whether sub-format is allowed or required depends
   on format)

  2. --input-format/--output-format options are removed,
     their function is now handled by <format> field
     of --io-encoding

  E.g.:
    --output file://- --io-encoding wav@s24/48000/stereo
     or
    --input file://- --io-encoding wav/-/-

  3. --print-supported is updated to discover and list all
     available sub-formats (divided into logical groups).

Docs
----

  1. Update --help messages of CLI tools.
  2. Update manual pages of CLI tools.

Internals
---------

Introduce concept of format (e.g. PCM, FLAC) and sub-format
(e.g. s16). Support formats and sub-formats in all sndio
backends.

roc_audio:

- SampleFormat => Format
- Formats: Format_Pcm, Format_Wav, Format_Custom
- PcmFormat => PcmSubformat
- SampleSpec: set_format(), set_custom_format(),
  set_pcm_subformat(), set_custom_subformat()
- SampleSpec: is_valid() => is_complete()
- Sample_RawFormat => PcmSubformat_Raw

roc_sndio:

- File formats are now *not* drivers. All file formats
  are handles by special "file://" driver, i.e.
  URI scheme is now always equal to driver.
- Supported file formats and sub-formats are
  discovered from backends separately from drivers.
- For discovery, we use DriverInfo and FormatInfo
  structs.

- IoConfig is empty by default; frame length and latency
  are zero.
- Each backend may use its own defaults for IoConfig.
- We can retrieve actually selected config using
  sample_spec() and frame_length() methods of IDevice.

- SoxBackend: remove file support, allow only devices
  (now we use sndfile for files)
- SoxBackend: support PCM format and sub-formats
- PulseaudioBackend: support PCM format and sub-formats
- SndfileBackend: support formats and sub-formats,
  map to sndfile major type and sub-type
- WavBackend: support WAV format and PCM sub-formats

- Refactoring & unification in sndio backends
- Bug-fixes in format handling in sndfile backend
gavv added a commit to gavv/roc-toolkit that referenced this issue Sep 11, 2024
@gavv
roc-streaminggh-608: Rename pcm_format to pcm_subformat
5712abe
gavv added a commit to gavv/roc-toolkit that referenced this issue Sep 11, 2024
@gavv
roc-streaminggh-608: Add native_alias to PcmTraits
17531b6
@gavv gavv closed this as completed Sep 12, 2024
@github-project-automation github-project-automation bot moved this from In work to Done in Roc Toolkit Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavv gavv

Labels
c api Task affects public C API enhancement
Projects
Roc Toolkit
Status: Done
Milestone
next
Development

No branches or pull requests
1 participant
@gavv