Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable payload type #116

Closed
gavv opened this issue Oct 22, 2017 · 3 comments
Closed

Configurable payload type #116

gavv opened this issue Oct 22, 2017 · 3 comments
Labels
duplicate Already addressed by another issue or pull request

Comments

@gavv
Copy link
Member

gavv commented Oct 22, 2017

Allow to configure payload type in sender (command line and public API). Payload type defines number of channels, sample format, and rate.

@dshil
Copy link
Member

dshil commented Nov 8, 2017

@gavv,

  • I think it'd be reasonable to have an option to see a list of currently supported payload types, wouldn't it?
  • How would we distinguish L16/mono and L16/stereo? In RFC2586 it's represented as one type.
  • I'll use a predefined list of known encoding formats from RFC3551

@gavv
Copy link
Member Author

gavv commented Nov 28, 2017

I think it'd be reasonable to have an option to see a list of currently supported payload types, wouldn't it?

Agree. Currently they're few, so we can just print them in --help.

How would we distinguish L16/mono and L16/stereo? In RFC2586 it's represented as one type.

https://tools.ietf.org/html/rfc3551#section-6

               10   L16         A           44,100       2
               11   L16         A           44,100       1

We already have these constants: https://github.com/roc-project/roc/blob/develop/src/modules/roc_rtp/headers.h#L31

I'll use a predefined list of known encoding formats from RFC3551

Yes, this is the correct RFC. See the link above to the concrete section.

@gavv gavv self-assigned this Jul 18, 2023
@gavv
Copy link
Member Author

gavv commented Oct 10, 2023

Will be covered in #608

@gavv gavv closed this as completed Oct 10, 2023
@gavv gavv added duplicate Already addressed by another issue or pull request and removed enhancement labels Oct 10, 2023
@gavv gavv removed their assignment Oct 10, 2023
@gavv gavv added this to Roc Toolkit Jul 6, 2024
@gavv gavv moved this to Done in Roc Toolkit Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Already addressed by another issue or pull request
Projects
Status: Done
Development

No branches or pull requests

2 participants