Support to add SAML token in message and attach pointer to the signature #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to think about this more. Expanding the token type support needs to be handle in a more extensible way as there are more than just SAML token (i.e. Kerberos). I'd like to find a more generic way to add the additional support to be able to plug in other token types |
|
Your approach towards handling different types of tokens in a generic and simple way sounds very good. I will check from my side too about this workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robrichards Your work for this library helped me a lot to resolve my integration of a complex webservice which required adding SAML auth token in the request. For that I needed these changes in the library. It will be great if you could merge this pull request. Thanks in advance!