Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for icub-tests context #1117

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

gsisinna
Copy link
Contributor

This fix the regression from #556. We tested it with:

yarp resource --context icubEth --from joint_limits_face.ini

Now $YARP_DATA_DIRS env variable points to the correct folder for icub-tests contexts.

cc @valegagge

@traversaro
Copy link
Member

Thanks @gsisinna !

Just for the sake of completeness, it useful to mentione that ideally we should not mention the source directory at all in the setup.sh, to avoid this kind of problems. See robotology/icub-tests#57 (comment) .

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you can update #1117 (comment) ?

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@traversaro traversaro merged commit c41e306 into robotology:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants