-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1137 #1139
Fix 1137 #1139
Conversation
I think there might be an issue with
|
I guess this will be fixed by https://github.com/robotology/idyntree/pull/1139/files#r1446594328 . |
Thanks a lot for the great work @mebbaid @S-Dafarra ! It is not a big problem in this case, but in the future if you could avoid making big whitespace/indent changes like the one in 2b644e9 mixed with actual changes it would be great, as the big whitespace/indentation changes make the actual changes difficult to read. In the merge, can I squash together the commits? Thanks! |
link simply against assimp::assimp Co-authored-by: Silvio Traversaro <[email protected]>
yeah, i relied too much on vscode for formating. But should pay attention to that.
yeah, thanks a lot! |
It is partially fault of iDynTree itself, we should just add a .clang-format file and live happy. |
* fix bypassing irrlicht index type rendering issue * use the correct itype with CDynamicMeshBuffer, some documentation * fix rendering issue related to Irrlicht limitaiton Co-authored-by: Silvio Traversaro <[email protected]>
This PR handles limitations imposed by
Irrlicht
on the number of vertices per rendered mesh.Related issue #1137