Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MeshcatVisualizer.cpp #1133

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update MeshcatVisualizer.cpp #1133

merged 1 commit into from
Jan 10, 2024

Conversation

G-Cervettini
Copy link
Contributor

This is missing on the master branch to be able to visualize the alpha channel in urdf models too.

@G-Cervettini
Update MeshcatVisualizer.cpp
b36290d 
This is missing on the master branch to be able to visualize the alpha channel in urdf models too.
@traversaro
Copy link
Member

traversaro commented Dec 14, 2023 •
edited
Loading

This is missing on the master branch to be able to visualize the alpha channel in urdf models too.

Sorry, I may be missing something:

  • Is this "missing on the master branch" and present somewhere else?
  • In which sense "too"?

@G-Cervettini
Copy link
Contributor Author

This is missing on the master branch to be able to visualize the alpha channel in urdf models too.

Sorry, I may be missing something:

  • Is this "missing on the master branch" and present somewhere else?
  • In which sense "too"?
  • No, I just meant that I applied it locally on my machine.
  • For primitive geometries like spheres it is possible to correctly visualize the alpha channel without this edit.

@traversaro
Copy link
Member

@GiulioRomualdi any specific objection?

@traversaro
Copy link
Member

@GiulioRomualdi any specific objection?

@GiulioRomualdi?

@GiulioRomualdi
Copy link
Member

Green flag for me. I'm sorry for the late response

@traversaro traversaro merged commit 51c31e2 into robotology:master Jan 10, 2024
18 checks passed
@G-Cervettini G-Cervettini deleted the patch-1 branch January 15, 2024 11:04
flferretti pushed a commit to flferretti/idyntree that referenced this pull request Dec 23, 2024
@G-Cervettini @flferretti
Update MeshcatVisualizer.cpp (robotology#1133)
b6782ac 
This is missing on the master branch to be able to visualize the alpha channel in urdf models too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiulioRomualdi GiulioRomualdi Awaiting requested review from GiulioRomualdi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@G-Cervettini @traversaro @GiulioRomualdi