-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imu test - test multiple IMUs and save data #69
Conversation
Changed base branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
Just a comment not blocking the PR!
In 46d8d1c I integrated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinaxgloria consider rebasing your branch over latest devel:
Introduced conda-based dependencies that speed up the CI. Please also enable this test in the CI and add the required dependencies
Yes, thanks @Nicogene, I'll do it |
96da5cc
to
1751ae1
Compare
In d35471a, I implemented the possibility of testing all the available IMUs by passing to the |
Tested on iCubGenova11: test-iCubGenova11.mp4Since robotology/icub-models-generator#233, the test result is: |
Great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @martinaxgloria!
Some small points to be addressed, but we have almost landed 🛬
Have you forgot to commit the move.sh
script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I forgot, now that the CI is conda based should be easy to enable the compilation of this test in the CI adding also the additional dependencies
This PR adds the possibility to run the test for multiple IMUs at a time to check the Euler angles values.
These changes were tested both in simulation and on the real robot (iCubGenova11).