Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit to set enable_tags and disable_tags in gzyarp::RobotInterface robotinterface #238

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Feb 17, 2025

Fix #163 .

This PR does the following (sorry for the relative big PR):

All these functionalities permit to write models in which some YARP devices created by the yarprobotinterface can be enabled and disabled, also from the world that includes the model.

A simple example of this functionality is:

    <model name="robotinterface_with_overriden_tags">
        <plugin name='gzyarp::ConfigurationOverride' filename='gz-sim-yarp-configurationoverride-system'>
            <!-- The yarpPluginConfigurationOverride device is used to override the configuration of
                 a given gzyarp::RobotInterface plugin, whose name (the one specified inside the xml file) is specified with yarpRobotInterfaceName, or you can specify `all` to ensure that the enable tags will be specified for all -->
            <yarpPluginConfigurationOverride yarpRobotInterfaceName='all'/>
            <yarpRobotInterfaceEnableTags>(enable_tag1)</yarpRobotInterfaceEnableTags>
            <yarpRobotInterfaceDisableTags>(disable_tagA disable_tagB)</yarpRobotInterfaceDisableTags>
        </plugin>
        <include>
            <uri>model://model_with_robotinterface_inside</uri>
        </include>
    </model>

(from the gzyarp::RobotInterface docs).

The implemented functionality has been validated with a dedicated RobotInterfaceTest.

@traversaro
Copy link
Member Author

There were a few issues, but now they are fixed and the tests are happy, the PR is ready for review.

Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super @traversaro !! I went through the code and tests and they look good to me! Thanks for also adding the related documentation.

Co-authored-by: Alessandro Croci <[email protected]>
@traversaro
Copy link
Member Author

Thanks, I applied your suggestions. If you agree I would squash and merge, and then release a tag a v0.4.0 release so that all users (even the one using conda packages) can use the improvements added to solve part of #229 .

@xela-95
Copy link
Member

xela-95 commented Feb 19, 2025

Thanks, I applied your suggestions. If you agree I would squash and merge, and then release a tag a v0.4.0 release so that all users (even the one using conda packages) can use the improvements added to solve part of #229 .

Perfect! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants