-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit to set enable_tags and disable_tags in gzyarp::RobotInterface robotinterface #238
Conversation
There were a few issues, but now they are fixed and the tests are happy, the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super @traversaro !! I went through the code and tests and they look good to me! Thanks for also adding the related documentation.
Co-authored-by: Alessandro Croci <[email protected]>
Thanks, I applied your suggestions. If you agree I would squash and merge, and then release a tag a v0.4.0 release so that all users (even the one using conda packages) can use the improvements added to solve part of #229 . |
Perfect! 🚀 |
Fix #163 .
This PR does the following (sorry for the relative big PR):
gzyarp::RobotInterface
(as otherwise it was impossible to document the new functionalities if we did not document the basic functionalities of the plugin)gzyarp::RobotInterface
to specifyenable_tags
anddisable_tags
(as described in YARP documentation, see https://www.yarp.it/latest/group__yarp__robotinterface__xml__config__files.html) via theyarpRobotInterfaceEnableTags
andyarpRobotInterfaceDisableTags
elements.yarpRobotInterfaceEnableTags
andyarpRobotInterfaceDisableTags
elements via thegzyarp::ConfigurationOverride
plugin added in Add gzyarp::ConfigurationOverride plugin to permit to override initialConfiguration tag in gzyarp::ControlBoard plugins #232 .All these functionalities permit to write models in which some YARP devices created by the yarprobotinterface can be enabled and disabled, also from the world that includes the model.
A simple example of this functionality is:
(from the
gzyarp::RobotInterface
docs).The implemented functionality has been validated with a dedicated
RobotInterfaceTest
.