Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel_skylib to 1.6.1 #111

Merged
merged 2 commits into from
May 18, 2024
Merged

Update bazel_skylib to 1.6.1 #111

merged 2 commits into from
May 18, 2024

Conversation

Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented May 18, 2024

Pulling in the latest bazel_skylib release and using the new module macros that it provides for the extensions.

@utzcoz
Copy link
Member

utzcoz commented May 18, 2024

@Bencodes please rebase.

@utzcoz
Copy link
Member

utzcoz commented May 18, 2024

@Bencodes Maybe we can try the hotfix version release cycle base these PRs? Looks like this PR changes the implementation of bazel extension of Robolectric.

@Bencodes Bencodes force-pushed the update-bazel_skylib-to-1.6.1 branch from 9938b66 to e39ee26 Compare May 18, 2024 16:07
@Bencodes
Copy link
Collaborator Author

@utzcoz yeah we can try it although these changes aren't urgent or required to get out in a release.

@Bencodes Bencodes merged commit 847e868 into master May 18, 2024
13 checks passed
@Bencodes Bencodes deleted the update-bazel_skylib-to-1.6.1 branch May 18, 2024 16:27
@utzcoz
Copy link
Member

utzcoz commented May 18, 2024

@Bencodes I got it. If it is not urgent, you can decide whether releasing a new patch/hotfix version of 4.12.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants