RPA.Windows Allow calling List Windows without getting process info
#1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmin764
approved these changes
Nov 21, 2023
| @@ -17,6 +17,7 @@ class WindowsElementsMixin: | |||
|
|
|||
| def __init__(self, locators_path: Optional[str] = None): | |||
| self.logger = logging.getLogger(__name__) | |||
| self.list_processes = True | |||
There was a problem hiding this comment.
Seems like a good way to control the library when we're about to decide if we want to list processes by PIDs or not.
But who/what sets this list_processes attribute (as False for e.g.) over the library object instance? And do you have a test/example showcasing the usage?
There was a problem hiding this comment.
Was planning to add keyword to Windows library to toggle this setting but obviously it requires first that this value exists in the core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.