Fixed re-orthogonalization in lsmr solver

robjhyndman · Jan 25, 2025 · fb9ce6a · fb9ce6a
1 parent c61cfb7
commit fb9ce6a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/R/lsmr.R b/R/lsmr.R
@@ -125,8 +125,8 @@ lsmr <- function(A,
 
   localVEnqueue <- function(v) {
     # Store v into the circular buffer localV.
-
-    if (localPointer < localSize) {
+    max_cols <- ncol(localV)
+    if (localPointer < max_cols) {
       localPointer <<- localPointer + 1
     } else {
       localPointer <<- 1
@@ -142,7 +142,7 @@ lsmr <- function(A,
 
     vOutput <- v
     if (localVQueueFull) {
-      localOrthoLimit <- localSize
+      localOrthoLimit <- ncol(localV)
     } else {
       localOrthoLimit <- localPointer
     }