Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the dependency of property num_atoms on the cube file content #65

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

robinzyb
Copy link
Owner

remove the dependency of property num_atoms on the cube file content. When writing a new cube file, the num_atoms property is obtained from self.stc which is ase Atoms object.

remove the dependency of property num_atoms on the cube file content.
When writing a new cube file, the num_atoms property is obtained from
self.stc which is ase Atoms object
@robinzyb robinzyb added the Enhancement New feature or request label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.60%. Comparing base (221ecdc) to head (5e512e3).
Report is 20 commits behind head on main.

Files Patch % Lines
cp2kdata/cube/cube.py 73.52% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   43.56%   43.60%   +0.04%     
==========================================
  Files          32       32              
  Lines        1988     2002      +14     
==========================================
+ Hits          866      873       +7     
- Misses       1122     1129       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinzyb robinzyb merged commit 1883beb into main Jul 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant